416322 - drag/drop all day event in multiweek and month view change the event's datetime

Status: VERIFIED WORKSFORME

(Calendar :: Calendar Frontend, defect)

Description

[Antoine BALLAGNY]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8.1.8) Gecko/20071004 Iceweasel/2.0.0.8 (Debian-2.0.0.8-1)
Build Identifier: version 2.0.0.9 (20071031) & Lightning (lightning.xpi	07-Feb-2008 20:06 - from ftp.mozilla.org)

After drop a all day event, between March, 28 2008 and April, 02 2008, (not for every days), event's datetime is corrupted.
I didn't find other days 

Reproducible: Always

Steps to Reproduce:
1.Create a allday event
2.drag and drop it between March, 28 2008 and April, 02 2008 (for exemple)

Actual Results:  
The event drop on a day, is placed the day before or after.
on this days, It occures very often only between March, 28 2008 and April, 02 2008


Expected Results:  
The event drop should be place on the day pointed.

It occure also in release 0.7 of lightning.

Comment 1

[Stefan Sitter [:ssitter]]

When does Daylight Saving Time start in your timezone? Maybe it's related to it.

Comment 2

[Andreas Treumann]

ssitter: that's correct, this bug is related by DST.

Set OS and Lighning timezone to Europe/Paris (DST start: the last Sunday in March). Drag a all day event from March 24th or March 30th to March 31th -> the all day event jumps to back to March 30th (last Sunday)

Set OS and Lighning timezone to America/New_York (DST start: first Sunday in April). Dragging an all day event from March 24th to March 31th works. But try to drag this all day event to April 6th -> the event jumps back to April 5th.

Comment 3

[Martin Schröder [:mschroeder]]

CONFIRMED per comment#2.

Comment 4

[Stefan Sitter [:ssitter]]

See Bug 372839 for a similar issue with non-all-day events that was fixed for Sunbird 0.5.

Comment 5

[Pete Riley]

(In reply to comment #2)
> Set OS and Lighning timezone to America/New_York (DST start: first Sunday in
> April). Dragging an all day event from March 24th to March 31th works. But try
> to drag this all day event to April 6th -> the event jumps back to April 5th.

I can reproduce the problem in the U.S.

However, it seems strange that you see the problem only when you drag the event past April 6th.  I see the problem when I drag the event to any day after March 9th.  March 9th is when DST starts this year in the U.S because the rules changed to these:

DST starts:  2nd Sunday in March     (i.e. 9 March 2008)
DST ends:    1st Sunday in November  (i.e. 2 November 2008)

Maybe your OS' timezone definitions do not have the current rules for the U.S. (if it helps, I use WinXP).  Anyway, this is a secondary problem.  As I said, I can reproduce this bug's main problem.

Comment 6

[Andreas Treumann]

@Pete Riley: Sorry, I checked this first with an older SuSe version. With SuSe 10.3 the bug occurs at March 9th/10th.

Comment 7

[Jochen Grotepass]

During Testing for Bug #416206 I found this issue too. When dragging All-Day Tasks and Events from outside the DST to inside DST, there is a bad behavior when dropping the task/event inside the DST. The duration in calendar-month-view.xml has a 23-Hour offset to reflect the DST. I modified the logic for this but this was a hack and not accepted. 
This also only occurs under Lightning (just tested with SunBird).

Comment 8

[Jochen Grotepass]

Forget the last sentence in comment #7. After testing with Patch from bug #416206 the same error exist also in Sunbird. Also the error than exist with Tasks.
The issue is in the addDuration logic for the AllDay-Type of entries.

Comment 9

[Simon Paquet [:sipaq]]

Not going to block on this, but we'll of course take the patch.

Comment 10

[:Hb]

Jochens patch to #416206 solved this issue.