Closed Bug 416326 Opened 15 years ago Closed 15 years ago

WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x804B000A in nsUrlClassifierDBService.cpp, line 3242

Categories

(Toolkit :: Safe Browsing, defect)

Product:
Toolkit
Component:
Safe Browsing
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3 beta4

People

(Reporter: reed, Assigned: dcamp)

Details

Attachments

(1 file)

fix
1.53 KB, patch
tony
: review+
Details | Diff | Splinter Review 
I'm getting this continuously in my debug build.

WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x804B000A: file /home/reed/mozilla/builds/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp, line 3242

3237  nsCAutoString key;
3238  // Canonicalize the url
3239  nsCOMPtr<nsIUrlClassifierUtils> utilsService =
3240    do_GetService(NS_URLCLASSIFIERUTILS_CONTRACTID);
3241  nsresult rv = utilsService->GetKeyForURI(uri, key);
3242  NS_ENSURE_SUCCESS(rv, rv);
Flags: blocking-firefox3?
Flags: blocking-firefox3? → blocking-firefox3+
Attached patch fix — — Splinter Review 
This is actually a pretty harmless failure.  It just means that the docshell requested classification of a URI with no hostname.  Attached patch switches this from an NS_ENSURE_SUCCESS() to an if (NS_FAILED()) to avoid the misleading console spew.

The patch also fixes an error propagation bug in this function's caller.
Assignee: nobody → dcamp
Status: NEW → ASSIGNED
Attachment #302222 - Flags: review?(tony)
Attachment #302222 - Attachment is patch: true
Attachment #302222 - Attachment mime type: application/octet-stream → text/plain
It may be pretty harmless, but it made my debugging session completely useless, as it filled my console with this warning. :)
Attachment #302222 - Flags: review?(tony) → review+
Keywords: checkin-needed
Checking in toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp,v  <--  nsUrlClassifierDBService.cpp
new revision: 1.60; previous revision: 1.59
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta4
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.