416326 - WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x804B000A in nsUrlClassifierDBService.cpp, line 3242

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Reed Loden [:reed]]

I'm getting this continuously in my debug build.

WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x804B000A: file /home/reed/mozilla/builds/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp, line 3242

3237  nsCAutoString key;
3238  // Canonicalize the url
3239  nsCOMPtr<nsIUrlClassifierUtils> utilsService =
3240    do_GetService(NS_URLCLASSIFIERUTILS_CONTRACTID);
3241  nsresult rv = utilsService->GetKeyForURI(uri, key);
3242  NS_ENSURE_SUCCESS(rv, rv);

Comment 1

[Dave Camp (:dcamp)]

Attachment: fix

This is actually a pretty harmless failure.  It just means that the docshell requested classification of a URI with no hostname.  Attached patch switches this from an NS_ENSURE_SUCCESS() to an if (NS_FAILED()) to avoid the misleading console spew.

The patch also fixes an error propagation bug in this function's caller.

Comment 2

[Reed Loden [:reed]]

It may be pretty harmless, but it made my debugging session completely useless, as it filled my console with this warning. :)

Comment 3

[Reed Loden [:reed]]

Checking in toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp,v  <--  nsUrlClassifierDBService.cpp
new revision: 1.60; previous revision: 1.59
done