Last Comment Bug 416403 - Queries not being cached?
: Queries not being cached?
Product: Graveyard
Classification: Graveyard
Component: API (show other bugs)
: unspecified
: All All
-- major
: 3.3
Assigned To: Fred Wenzel [:wenzel]
Depends on:
  Show dependency treegraph
Reported: 2008-02-08 11:39 PST by Mark Smith [:xb95]
Modified: 2016-02-04 14:47 PST (History)
6 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

ltrim queries to get rid of leading whitespace (553 bytes, patch)
2008-02-08 12:43 PST, Fred Wenzel [:wenzel]
morgamic: review+
Details | Diff | Splinter Review

Description User image Mark Smith [:xb95] 2008-02-08 11:39:04 PST

There are a lot of queries that are being sent against the database multiple times a second that are identical, version checks for the same addons, etc.

(Not sure what else to put here?)
Comment 1 User image Laura Thomson :laura 2008-02-08 11:49:47 PST
I'm not sure this is the API but seems entirely possible.

Is web server traffic spiking as well?  on what pages?
Comment 2 User image Fred Wenzel [:wenzel] 2008-02-08 12:43:27 PST
Created attachment 302170 [details] [diff] [review]
ltrim queries to get rid of leading whitespace

Queries with leading whitespace were not memcached. Ouch.

morgamic, please review.
Comment 3 User image Fred Wenzel [:wenzel] 2008-02-08 12:57:34 PST
FIXED in r10123 (trunk) and r10124 (reskin branch). Marking push-needed.
Comment 4 User image Jeremy Orem [:oremj] 2008-02-08 13:04:30 PST
Woo good find!
Comment 5 User image Fred Wenzel [:wenzel] 2008-02-08 13:13:40 PST
heh, thanks -- I just want to be good friends with the database, that's all ;)
Comment 6 User image Justin Scott [:fligtar] 2008-02-14 16:34:37 PST
This is live.

Note You need to log in before you can comment on or make changes to this bug.