416425 - Home button doesn't show icon in customize window when dragged from Bookmarks Toolbar

Status: REOPENED

(Firefox :: Toolbars and Customization, defect)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008020804 Minefield/3.0b4pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008020804 Minefield/3.0b4pre

If I drag Home from the (default) Bookmarks Toolbar to the customize toolbars window, it appears as text only instead of icon & text like everything else in the window.  Once dragged to the Navigation Toolbar it converts to an icon but when dragged back to the customizing preference pane, it reverts to text only.

Reproducible: Always

Steps to Reproduce:
1. Right-click on the navigation toolbar and select "Customize..."
2. Drag "Home" from the Bookmarks toolbar into customize window
3. 
Actual Results:  
Home is represented as text only while all the others are text and icons.

Expected Results:  
There should be an icon as well as text for Home

see screenshot.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Screenshot of text-only Home button in customize window

Comment 2

[Marcia Knous [:marcia]]

Confirming. I could not find a dupe of this. I see it using both the Beta 3 candidate Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3 as well as the nightly. 

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Me neither; guess I was thinking of something else.  Thanks for filing, lsblakk.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

With a little more poking, I have discovered that if I put Home on the navigation bar (thus activating the icon) and put it back in the customize window, restart FF without Home being on any toolbars, then when I re-open the customize window Home now has icon & text.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Related to bug 422420 - or at least to the new problem that we're seeing there?

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

I think that this is actually related to bug 423770, which may have been caused by bug 414864, but it's hard to tell.

Not a blocker, though. Just kinda strange.

Comment 7

[Dão Gottwald [:dao]]

I'm not seeing this on Windows. Did bug 422420 fix this?

Comment 8

[Phil Ringnalda (:philor)]

No, it's still possible to reproduce, it's just not as obvious since it's now small icon + text, and takes a few more steps now that it's not on the bookmarks toolbar by default:

1. Customize, drag Home to bookmarks toolbar.
2. Flush localstore.rdf (the simplest way is to close and reopen Fx).
3. Customize, drag to palette, note small icon with text on the right. (Close and reopen if you want, should still be small + text on right.)
4. Customize, drop on nav toolbar, should appear correct.
5. Drag back to palette, back to small + text.
6. Drop on nav toolbar, close customization, close and reopen Fx.
7. Customize again, drag from nav toolbar to palette, should now be large with text below.

I think the problem is that although BrowserToolboxCustomizeChange is calling through to updatePersonalToolbarStyle on all those drops, updatePersonalToolbarStyle is looking for the home-button to be in its document, even when it's actually in the palette's document. So, oddly enough, on Mac, where this was reported, it's now WFM because the palette's actually a panel in the browser's document, but on Windows/Linux it isn't.

The right fix, teaching updatePersonalToolbarStyle to look elsewhere if it doesn't find it in the browser doc, is likely to be a little large at this point, but a style rule for [place="palette"] that overrides the .bookmark-item rules for small + text on right ought to be pretty safe.

Comment 9

[Brian]

Hi

I'm also getting this bug in the following:
DELL Inspiron laptop running Windows XP Sp2 (ie non-Mac)
Firefox 2.0.0.13
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13)
Gecko/20080311 Firefox 2.0.0.13

The Home button is missing even if dragged to another toolbar, such as address or navigation or back to Customize Window. Nothing I do makes it reappear.

I've tried removing the button to the Customize Window, closing FF and then reopening FF and moving the button from the Customize Window back to the Navigation toolbar - but still no joy.  Home button still has no icon.

Don't understand Phil Ringnalda's reference to palette in steps 3, 5 and 7 BTW.

B

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Just checked this again on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4 and the issue seems to have been resolved.  Since this bug was never claimed it's probably a moot point now.

Closing.

Comment 11

[Phil Ringnalda (:philor)]

Every bit of comment 8 remains true (including the fact that it's wfm on Mac because on Mac the palette is in the same document as the toolbars).

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)