416446 - Make PluralForm more useful for extensions and delay importing strings for perf

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Ed Lee :Mardak]

Extensions will have troubles using PluralForm because it uses the browser's plural rule, but if the extension isn't localized to the same rule, there'll be issues. So instead, we can provide a "makeGet" method that basically creates a "PluralForm" for an input plural rule. Now extensions can specify their own plural rule number.

Also, we can avoid loading the pluralRule string until we really need to on first access to help perf.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Plus testcase! :)

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 302205 [details] [diff] [review]
v1

Not going to get to review this, canceling the request.

Comment 3

[Ed Lee :Mardak]

Comment on attachment 302205 [details] [diff] [review]
v1

r?sdwilsh as this code was going to be in toolkit/ download stuff originally. So perhaps smontagu can give an official r+ if sdwilsh r+s.

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 302205 [details] [diff] [review]
v1

r=sdwilsh, but how about makeGetter instead?

Comment 5

[Ed Lee :Mardak]

Attachment: v1.1

(In reply to comment #4)
> (From update of attachment 302205 [details] [diff] [review])
> r=sdwilsh, but how about makeGetter instead?
Sure.

r?smontagu for official review to land

Also reordered the return value to be get then numForms to be more consistent with what the consumer probably wants, so the second thing can be easily dropped off.

Comment 6

[Ed Lee :Mardak]

Added section http://developer.mozilla.org/en/docs/Localization_and_Plurals#Developing_with_PluralForm

Comment 7

[Damon Sicore (:damons)]

Comment on attachment 305292 [details] [diff] [review]
v1.1

a1.9+=damons

Comment 8

[Ed Lee :Mardak]

Checking in intl/locale/src/PluralForm.jsm;
/cvsroot/mozilla/intl/locale/src/PluralForm.jsm,v  <--  PluralForm.jsm
new revision: 1.5; previous revision: 1.4
done
RCS file: /cvsroot/mozilla/intl/locale/tests/unit/test_pluralForm_makeGetter.js,v
done
Checking in intl/locale/tests/unit/test_pluralForm_makeGetter.js;
/cvsroot/mozilla/intl/locale/tests/unit/test_pluralForm_makeGetter.js,v  <--  test_pluralForm_makeGetter.js
initial revision: 1.1
done

Comment 9

[Ed Lee :Mardak]

Sheppy: Should there be a link to Localization_and_Plurals from either/both of these pages?

http://developer.mozilla.org/en/docs/JavaScript_modules
http://developer.mozilla.org/en/docs/Firefox_3_for_developers#For_XUL_and_extension_developers

I added this section for this bug:
http://developer.mozilla.org/en/docs/Localization_and_Plurals#Developing_with_PluralForm