Closed
Bug 416584
Opened 16 years ago
Closed 16 years ago
Drag and drop of an ics file over calendar icon is not handled correctly
Categories
(Calendar :: Lightning Only, defect)
Calendar
Lightning Only
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: b_straub, Assigned: berend.cornelius09)
References
Details
(Keywords: regression)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; de; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12 Build Identifier: 2008020819 Drag and drop of an ics file over calendar is not handled correctly. After dragging the ics the new event dialog opens, however "Safe and close" does not raise any effect. Reproducible: Always Steps to Reproduce: 1. Send an email with attached ics to Thunderbird 2. Drag the ics over the calendar icon 3. Hit "Save and close" in the new event dialog Actual Results: "Save and close" does not have any effect. New event dialog stays open. Expected Results: "Save and close" safes the event to the selected calendar and closes dialog.
Reporter | ||
Updated•16 years ago
|
Flags: blocking-calendar0.8+
Comment 1•16 years ago
|
||
From my understanding dragging attachments to the Calendar icon is not supported. You need to drag the entire email to create an event from it. And if the ics file is correctly embedded in the email you should see the calendar bar with the accept/decline buttons for the invitations.
Summary: Drag and drop of an ics file over calendar is not handled correctly → Drag and drop of an ics file over calendar icon is not handled correctly
Reporter | ||
Comment 2•16 years ago
|
||
This might be a misunderstanding. The ics files I refer to are not generated from e.g. Outlook invitation. I refer to those ics files that are e.g. attached to a Lufthansa flight confirmation. In this case you'll get a normal mail where the flight dates are attached as ics files e.g. xxxx_Flug_1.ics. Dragging those attachments over the calendar icon below the mail pane opens the new event dialog so seems to be brilliant. However the behavior of "Safe and Close" is not as expected. Note: referring to nightly build 2008020819
Comment 3•16 years ago
|
||
Only release drivers are allowed to grant blocking-calendar0.8.
Flags: blocking-calendar0.8+ → blocking-calendar0.8?
Comment 4•16 years ago
|
||
Not going to happen in 0.8. We're already to far along for such feature requests.
Flags: blocking-calendar0.8? → blocking-calendar0.8-
Comment 5•16 years ago
|
||
Error in the console: Fehler: item.calendar has no properties Quelldatei: chrome://calendar/content/calUtils.js Zeile: 2008 That's the second line in setItemProperty function: function setItemProperty(item, propertyName, aValue, aCapability) { var isSupported = (item.calendar.getProperty("capabilities." + aCapability + ".supported") == false) var value = (aCapability && !isSupported ? null : aValue);
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 6•16 years ago
|
||
Bernhard, did this work in a older nightly build, e.g. the 20080207 one? The method setItemProperty() has been changed recently with Bug 327780 causing other regressions too.
Reporter | ||
Comment 7•16 years ago
|
||
I remember that described funtionality has been working with a build some weeks ago. Unfortunately I can't tell you exact revision number.
Comment 8•16 years ago
|
||
Could you download and test with previous nightly builds from <http://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/> to narrow down the regression range?
Reporter | ||
Comment 9•16 years ago
|
||
Drag and drop feature was implemented "20071215". Did not find an intermediate release where "Safe and close" working since stated release "2008020819". Tested: 20071215 20071220 20071220 20080110
Assignee | ||
Comment 10•16 years ago
|
||
As I tested this is duplicate.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
Comment 11•16 years ago
|
||
Berend, how is the patch in Bug 416525 supposed to fix the error in this bug, see Comment #5? See also Bug 327780 Comment #43.
Comment 12•16 years ago
|
||
Tested with hourly (including patch from bug 416525). This is _not_ fixed.
Status: VERIFIED → REOPENED
Resolution: DUPLICATE → ---
Comment 13•16 years ago
|
||
Lightning 2008021118 -> Output error console: Error: item.calendar has no properties Source File: chrome://calendar/content/calUtils.js Line: 2008
Comment 14•16 years ago
|
||
Can anyone confirm the regression range mentioned in Comment #6? Did it worked before? Quoting myself from Bug 327780 Comment #43: The change in setItemProperty() might also have regressed this bug. I assume that for new created events/tasks the calendar is not yet set on the event/task. Previously the calendar was taken from the corresponding dropdown menu in the dialog (via function capSupported() in sun-calendar-event-dialog.js).
Comment 15•16 years ago
|
||
@ssitter: last build with no problems: 2008020719, first build with this bug: 2008020819.
Comment 16•16 years ago
|
||
This confirms that this bug is indeed a regression from Bug 327780. In my opinion the blocking‑calendar0.8- decision from Comment #4 should be reevaluated.
Blocks: 327780
Keywords: regression
Comment 17•16 years ago
|
||
Trying a task->task or event->event conversion generates the same error console output. Also the actual result is the same: "Save and close" does not have any effect. New event dialog stays open.
Comment 18•16 years ago
|
||
Re-nominating for blocking-calendar0.8.
Flags: blocking-calendar0.8- → blocking-calendar0.8?
OS: Windows XP → All
Hardware: PC → All
Updated•16 years ago
|
Assignee: nobody → Berend.Cornelius
Status: REOPENED → NEW
Flags: blocking-calendar0.8? → blocking-calendar0.8+
Assignee | ||
Comment 19•16 years ago
|
||
in reply to comment #11: I am sorry I tested the issue in a slight different way than described and found it was fixed -> but it was not. As I checked out the problem is that the imported items do not contain calendars. As the solution touches the same source code as bug 413159 I would like to set this issue to duplicate to bug 416584.
Assignee | ||
Comment 20•16 years ago
|
||
Issue is fixed in the current build...
Status: NEW → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Target Milestone: --- → 0.8
Comment 21•16 years ago
|
||
Checked with latest lightning build 2008030219 -> task is fixed and verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•