416685 - jsinterp.c warning: empty body in an if-statement (times 4)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[jag (Peter Annema)]

Attachment: Use JS_{BEGIN,END}_MACRO

Just a minor warning, but easily addressed:

../../../mozilla/js/src/jsinterp.c: In function 'js_Interpret':
../../../mozilla/js/src/jsinterp.c:3165: warning: empty body in an if-statement
../../../mozilla/js/src/jsinterp.c:3941: warning: empty body in an if-statement
../../../mozilla/js/src/jsinterp.c:4028: warning: empty body in an if-statement
../../../mozilla/js/src/jsinterp.c:4602: warning: empty body in an if-statement

Comment 1

[Brendan Eich [:brendan]]

Ugh. How about ((void)0) instead of /* nothing */ and we keep the one-line macro definitions?

/be

Comment 2

[jag (Peter Annema)]

I'm fine with that too. I was trying to let us be able to handle code like:

  if (foo)
    PCMETER(a++; b--);

but that's over-kill. New patch coming up.

Comment 3

[jag (Peter Annema)]

Attachment: Use ((void)0)

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 302491 [details] [diff] [review]
Use ((void)0)

Thanks, jag.

/be

Comment 5

[jag (Peter Annema)]

Checking in jsinterp.h;
/cvsroot/mozilla/js/src/jsinterp.h,v  <--  jsinterp.h
new revision: 3.71; previous revision: 3.70
done