Created attachment 302425 [details] [diff] [review] patch Bug 409284 added overly aggressive error checking to bloatdiff, which causes it to bail if there are no leaks (or if the percent leaks is 0 due to roundoff). Firefox is green only because build-seamonkey-util.pl ignores bloatdiff's failure to run.
Attachment #302425 - Flags: review?(ccooper)
Comment on attachment 302425 [details] [diff] [review] patch Can you add a comment in the code as to why we don't check leaked or leakPercent? It will make it easier for the next person who has to touch this code. r+ with that.
Attachment #302425 - Flags: review?(ccooper) → review+
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Component: Tinderbox Configuration → Tinderbox
Product: mozilla.org → Webtools
You need to log in before you can comment on or make changes to this bug.