Closed
Bug 416728
Opened 16 years ago
Closed 16 years ago
update pinstripe for bug 414366
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3
People
(Reporter: dao, Assigned: shorlander)
References
Details
Attachments
(2 files, 1 obsolete file)
29.33 KB,
image/png
|
beltzner
:
ui-review+
beltzner
:
approval1.9+
|
Details |
2.66 KB,
patch
|
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
I don't have adequate back/forward icons, so I'm outsourcing this.
Flags: blocking-firefox3?
Comment 1•16 years ago
|
||
Not blocking on this, as it's less important for OSX where these sorts of context menu icons are really uncommon.
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
Assignee | ||
Comment 3•16 years ago
|
||
Assignee | ||
Comment 4•16 years ago
|
||
Patch to add back/forward icons to Proto.
Attachment #318383 -
Flags: ui-review?
Attachment #318383 -
Flags: review?
Reporter | ||
Comment 5•16 years ago
|
||
Comment on attachment 318383 [details] [diff] [review] Patch to add back/forward icons to keyhole dropdown >Index: browser/themes/pinstripe/browser/browser.css >+.unified-nav-back[_moz-menuactive], >+menupopup[chromedir="rtl"] > .unified-nav-forward[_moz-menuactive] { >+list-style-image: url("chrome://browser/skin/menu-back.png") !important; nit: 2 spaces indention
Attachment #318383 -
Flags: ui-review?(beltzner)
Attachment #318383 -
Flags: ui-review?
Attachment #318383 -
Flags: review?
Attachment #318383 -
Flags: review+
Assignee | ||
Comment 6•16 years ago
|
||
(In reply to comment #5) > nit: 2 spaces indention > Thanks! Fixed that. Should I attach a new patch for new review?
Reporter | ||
Comment 7•16 years ago
|
||
Unless you will be able to check it in yourself, you should attach a new patch, but no new review is needed.
Reporter | ||
Updated•16 years ago
|
Attachment #318382 -
Flags: ui-review?(beltzner)
Reporter | ||
Updated•16 years ago
|
Attachment #318383 -
Flags: ui-review?(beltzner)
Reporter | ||
Updated•16 years ago
|
Assignee: kevin → stephen
Assignee | ||
Comment 8•16 years ago
|
||
Added spaces. Requesting 1.9 Approval.
Attachment #318383 -
Attachment is obsolete: true
Attachment #318393 -
Flags: approval1.9?
Updated•16 years ago
|
Attachment #318382 -
Flags: ui-review?(beltzner)
Attachment #318382 -
Flags: ui-review+
Attachment #318382 -
Flags: approval1.9+
Updated•16 years ago
|
Attachment #318393 -
Flags: approval1.9? → approval1.9+
Comment 9•16 years ago
|
||
Is this ready to be checked-in?
Updated•16 years ago
|
Status: NEW → ASSIGNED
Comment 10•16 years ago
|
||
It looks like Stephen has to attach menu-back.png and menu-forward.png before this can be checked in, right?
Assignee | ||
Comment 11•16 years ago
|
||
(In reply to comment #9) > Is this ready to be checked-in? > Sorry, forgot to update this. Checked in on 2008-04-29 mozilla/browser/themes/pinstripe/browser/browser.css 1.150 mozilla/browser/themes/pinstripe/browser/jar.mn 1.87 mozilla/browser/themes/pinstripe/browser/menu-back.png 1.1 mozilla/browser/themes/pinstripe/browser/menu-forward.png 1.1
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 12•16 years ago
|
||
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050918 Minefield/3.0pre ID:2008050918
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 3
You need to log in
before you can comment on or make changes to this bug.
Description
•