Closed
Bug 416756
Opened 16 years ago
Closed 16 years ago
Handle crashes in all a11y COM interfaces
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
Details
(Keywords: access)
Attachments
(1 file)
|
76.68 KB,
patch
|
surkov
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
In bug 381049 we began to pass swallowed COM crashes to breakpad. COM automatically catches access violations and does not terminate the app. Therefore crashes were not getting reported, and screen readers were not getting the return from a call. We now pass these internal crashes to breakpad. Let's do this for ISimpleDOM*, IAccessible*, etc. No need to file a separate bug for each. We can do it with one patch.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #302515 -
Flags: review?(surkov.alexander)
|
||
Comment 2•16 years ago
|
||
Why do we return S_OK but sometimes E_FAIL after the crash?
|
|
||
Comment 3•16 years ago
|
||
Comment on attachment 302515 [details] [diff] [review] Use __try/__catch with FilterA11yExceptions r=me with addressed comment #2
Attachment #302515 -
Flags: review?(surkov.alexander) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
We just need to return something there it it won't compile. But it actually never returns after the crash, so it doesn't even get to that line.
|
|
Assignee | |
Updated•16 years ago
|
Attachment #302515 -
Flags: approval1.9?
|
||
Updated•16 years ago
|
Attachment #302515 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•