416762 - OBJECTBOUNDINGBOX units should include a translation by the boundingbox origin

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

In two places we use nsSVGUtils::ObjectSpace to interpret x/y/width/height coordinates according to objectBoundingBox units, without using the bounding-box origin as a translation:

Patterns:
http://mxr.mozilla.org/seamonkey/source/layout/svg/base/src/nsSVGPatternFrame.cpp#643

Filter primitive subregions:
http://mxr.mozilla.org/seamonkey/source/layout/svg/base/src/nsSVGFilterFrame.cpp#451

These are both bugs, right? The spec says
http://www.w3.org/TR/SVG/coords.html#ObjectBoundingBox
> Then, coordinate (0,0) in the new user coordinate system is mapped to the
> (minx,miny) corner of the tight bounding box within the user coordinate system
> of the applicable element
which is of course what authors would expect too.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: testcase

This testcase shows the problem. It doesn't display anything on trunk. It should display a green rectangle.

I've fixed this for filter subregions in my patch for bug 414784. Still probably need a fix for patterns, although I don't have a testcase for that.

Comment 2

[Robert Longson [:longsonr]]

Didn't I do patterns in bug 338596, although that patch wasn't quite right and I had to fix it in bug 261693? 

Comment 3

[Robert Longson [:longsonr]]

s/261693/377263/

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

OK cool. Would you mind manufacturing a reftest for that and checking it in? Then I'll close this bug :-).

Comment 5

[Robert Longson [:longsonr]]

Attachment: pattern reftest

Comment 6

[Robert Longson [:longsonr]]

Checked in pattern reftests:
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/objectBoundingBox-and-pattern-01a.svg
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/objectBoundingBox-and-pattern-01b.svg
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/objectBoundingBox-and-pattern-01c.svg

Comment 7

[Robert Longson [:longsonr]]

FWIW the pattern translation code is here
http://mxr.mozilla.org/seamonkey/source/layout/svg/base/src/nsSVGPatternFrame.cpp#735

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Cool, I'll close this down now. The filter stuff will be fixed in bug 414784.