416819 - Places Organizer menu selection

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[Michael Monreal [:micmon]]

The places organizer is using a proper menu instead of menu-like behaving buttons now. This is great, but the font color of the selected menu is wrong (see screenshot).

Comment 1

[Michael Monreal [:micmon]]

Attachment: Screenshot

Comment 2

[Teune van Steeg]

This might be a dupe of bug 416410, since the menu is intended to have a toolbar button appearance, in which case the text color is correct.

Comment 3

[Michael Monreal [:micmon]]

(In reply to comment #2)
> This might be a dupe of bug 416410, since the menu is intended to have a
> toolbar button appearance, in which case the text color is correct.
> 

Hmm? Why that! It makes totally sense to have manu appearanace for this, as it *is* a menu (which also has two buttons at the start, but that's not the point, the same is possible to do in the main browser window). We have toolbar button appearance for bookmark folders, let's not mix those two up.

Comment 4

[Michael Ventnor]

(In reply to comment #3)
> (In reply to comment #2)
> > This might be a dupe of bug 416410, since the menu is intended to have a
> > toolbar button appearance, in which case the text color is correct.
> > 
> 
> Hmm? Why that! It makes totally sense to have manu appearanace for this, as it
> *is* a menu (which also has two buttons at the start, but that's not the point,
> the same is possible to do in the main browser window). We have toolbar button
> appearance for bookmark folders, let's not mix those two up.
> 

Its mixed with back and forward which ARE buttons. Menubars should always be on their own row and contain only menus, otherwise ugliness results as you can see with some themes.

Comment 5

[Michael Monreal [:micmon]]

Attachment: Main window

The screenshot shows that it is possible to use buttons and menus together in the main window (which I personally know some people use to save space). I don't see a problem at all to have buttons and a "Organize  View  Backup" menu in one line. I see however a problem with buttons that work like a menu but look like bookmarks.

Comment 6

[Dão Gottwald [:dao]]

I agree: this should be styled like a menu, because it is a menu (feature wise and -- as of bug 400703 -- implementation wise). However, some themes do make the assumption that the menu is on the top and has no siblings (e.g. attachment 302902 [details]).

Comment 7

[Michael Monreal [:micmon]]

(In reply to comment #6)
> However, some themes do make
> the assumption that the menu is on the top and has no siblings (e.g. attachment
> 302902 [details]).
> 

Is this the Darkilouche theme or some other theme using the same colors? making this assumption seems to be a very bad idea btw becasue it will break other apps as well.

Comment 8

[Dão Gottwald [:dao]]

(In reply to comment #7)
> Is this the Darkilouche theme or some other theme using the same colors?

I don't know. It's a screenshot from bug 417087.

Comment 9

[Michael Monreal [:micmon]]

(In reply to comment #8)
> I don't know. It's a screenshot from bug 417087.

Ok, confirmed as Darkgilouche. Jimmac confirmed this as bug in his theme, as he basicly uses a hack but didn't get the widget matches right. So this should not be seen as a problem here. I tested other themes/engines and they all seemed to work fine.

Comment 10

[Michael Ventnor]

The Glossy theme on Ubuntu (which I use) also shows a similar problem.

Comment 11

[Michael Monreal [:micmon]]

The attachment¹ even shows that the affected themes also have problems elsewhere in the desktop: see the "live session user" applet in the top panel bar, it also should use the brighter gray (like the panel itself) and not the dark one. Same for Gummy, right. 

[1] https://bugzilla.mozilla.org/attachment.cgi?id=302902

Comment 12

[Dão Gottwald [:dao]]

When bug 416410 is fixed, just #placesMenu { -moz-appearance: none } would probably fix the problem that we have with some themes' menu appearance.

Comment 13

[u294409]

"However, some themes do make
the assumption that the menu is on the top and has no siblings"

Menu is menu. It SHOULD have own toolbar.

But if we move library's menubar to the top, we will have lots of unused space...

Comment 14

[Ian Spence]

so... fixed?

Comment 15

[Michael Ventnor]

I'd say invalid. We don't need to do anything here.