416843 - gqi.py generates dependency information that MSYS doesn't understand

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[[e-mail]]

MSYS accepts either Unix paths or absolute DOS paths. However gqi.py generates relative paths containing backslashes. MSYS Perl does not understand that.

Comment 1

[jag (Peter Annema)]

A pretty simple fix Neil tested this morning was to replace |os.path.join(dir, f)| with |dir + "/" + f|

Comment 2

[Benjamin Smedberg]

Seems like it would be just as simple to do replace('\\', '/') on output.

Comment 3

[[e-mail]]

There's no point because that's the only place a backslash can ever be generated; all the input paths use forward slashes.

Comment 4

[jag (Peter Annema)]

Attachment: Use posix path manipulation since we always want '/'

I think it's safe to do this since |f| will never contain an absolute path.

Comment 5

[Benjamin Smedberg]

Comment on attachment 302825 [details] [diff] [review]
Use posix path manipulation since we always want '/'

Don't you need to import posixpath?

Comment 6

[jag (Peter Annema)]

Ah, yep, thanks. It didn't like my not adding posixpath to the import line. Consider it added. I'll attach a new patch if we can all agree on using this approach (vs +"/"+ or doing a global replace of '\' with '/'.

Comment 7

[Benjamin Smedberg]

r=me for the posixpath approach

Comment 8

[jag (Peter Annema)]

Attachment: Use posixpath.join(); we always want '/'.

Comment 9

[jag (Peter Annema)]

Checking in gqi.py;
/cvsroot/mozilla/xpcom/base/gqi.py,v  <--  gqi.py
new revision: 1.3; previous revision: 1.2
done