Closed Bug 416843 Opened 14 years ago Closed 14 years ago

gqi.py generates dependency information that MSYS doesn't understand

Categories

(Firefox Build System :: General, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: jag+mozilla)

References

Details

Attachments

(1 file, 1 obsolete file)

MSYS accepts either Unix paths or absolute DOS paths. However gqi.py generates relative paths containing backslashes. MSYS Perl does not understand that.
A pretty simple fix Neil tested this morning was to replace |os.path.join(dir, f)| with |dir + "/" + f|
Seems like it would be just as simple to do replace('\\', '/') on output.
There's no point because that's the only place a backslash can ever be generated; all the input paths use forward slashes.
I think it's safe to do this since |f| will never contain an absolute path.
Comment on attachment 302825 [details] [diff] [review]
Use posix path manipulation since we always want '/'

Don't you need to import posixpath?
Ah, yep, thanks. It didn't like my not adding posixpath to the import line. Consider it added. I'll attach a new patch if we can all agree on using this approach (vs +"/"+ or doing a global replace of '\' with '/'.
r=me for the posixpath approach
Assignee: nobody → jag
Attachment #302825 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #302985 - Flags: review+
Attachment #302985 - Flags: approval1.9?
Attachment #302985 - Flags: approval1.9? → approval1.9+
Checking in gqi.py;
/cvsroot/mozilla/xpcom/base/gqi.py,v  <--  gqi.py
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.