Closed
Bug 416845
Opened 17 years ago
Closed 16 years ago
"ASSERTION: Unexpected position"
Categories
(Core :: Layout: Tables, defect)
Core
Layout: Tables
Tracking
()
RESOLVED
FIXED
mozilla1.9.1a2
People
(Reporter: jruderman, Assigned: MatsPalmgren_bugz)
References
Details
(Keywords: assertion, testcase)
Attachments
(4 files)
|
138 bytes,
application/xhtml+xml
|
Details | |
|
359 bytes,
application/xhtml+xml
|
Details | |
|
802 bytes,
text/html
|
Details | |
|
1.97 KB,
patch
|
bernd_mozilla
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Loading the testcase triggers:
###!!! ASSERTION: Unexpected position: 'rgFrame->GetPosition().x == 0', file /Users/jruderman/trunk/mozilla/layout/tables/nsTableFrame.cpp, line 3446
|
Assignee | |
Comment 1•16 years ago
|
||
|
|
Assignee | |
Comment 2•16 years ago
|
||
Same thing in HTML, this produces the same frame tree as #2.
|
|
Assignee | |
Comment 3•16 years ago
|
||
I think this assertion is wrong, setting the x-position to zero
actually causes a layout bug.
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/tables/nsTableFrame.cpp&rev=3.724&root=/cvsroot&mark=3424,3499,3500#3424
OS: Mac OS X → All
Hardware: PC → All
|
|
Assignee | |
Comment 4•16 years ago
|
||
Assignee: nobody → mats.palmgren
Status: NEW → ASSIGNED
Attachment #330472 -
Flags: superreview?(dbaron)
Attachment #330472 -
Flags: review?(dbaron)
|
||
Comment 5•16 years ago
|
||
Yeah, I just asserted it so that we'd catch this bug if the 0 was wrong...
Boris, if you're familiar with the code in question, did you want to review the patch?
|
|
||
Comment 7•16 years ago
|
||
Comment on attachment 330472 [details] [diff] [review]
Patch rev. 1
I can certainly sr. I think bernd should review.
Attachment #330472 -
Flags: superreview?(dbaron)
Attachment #330472 -
Flags: superreview+
Attachment #330472 -
Flags: review?(dbaron)
Attachment #330472 -
Flags: review?(bernd_mozilla)
Comment on attachment 330472 [details] [diff] [review]
Patch rev. 1
makes sense
Attachment #330472 -
Flags: review?(bernd_mozilla) → review+
|
|
||
Comment 10•16 years ago
|
||
Checked in, with the tests.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2
You need to log in
before you can comment on or make changes to this bug.
Description
•