Closed Bug 416905 Opened 15 years ago Closed 11 years ago

Directory removal of extension installed as pointer file isn't uninstalled correctly

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla6

People

(Reporter: mossop, Assigned: mossop)

References

Details

Attachments

(1 file)

patch rev 1
2.01 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review 
For an extension that is installed with a pointer file if the directory pointed at goes away the extension isn't cleanly uninstalled.

It seems that on startup the EM notices that the directory has gone and logs that it is going to uninstall, then something that isn't logged appears to go wrong and then it fails to write out extensions.ini throwing a file not found error from getAbsoluteDescriptor.

Not a common case I think but would be nice to fix if it's simple.
Product: Firefox → Toolkit
Dave, I assume we can close out this bug now? A lot of work happened in that area for the rewrite and I think we have covered this case. But not completely sure off-hand.
It works, except it leaves the stale pointer file around, I think we should delete it when we know it has become bad. Also needs a test.
Assignee: nobody → dtownsend
Flags: in-testsuite?
Attached patch patch rev 1 — — Splinter Review
Attachment #532059 - Flags: review?(robert.bugzilla)
Whiteboard: [has patch][needs review rs]
Comment on attachment 532059 [details] [diff] [review]
patch rev 1

Looks good and shouldn't have problems with file in use on Windows with the directLoad being false. :)
Attachment #532059 - Flags: review?(robert.bugzilla) → review+
Whiteboard: [has patch][needs review rs] → [has patch]
Blocks: 466298
Landed: http://hg.mozilla.org/mozilla-central/rev/de3e9983db1b
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite?
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch]
Target Milestone: --- → mozilla6
Verified with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a2) Gecko/20110529 Firefox/6.0a2 ID:20110529042002
Status: RESOLVED → VERIFIED
OS: Mac OS X → All
Hardware: x86 → All
Version: Trunk → 2.0 Branch
You need to log in before you can comment on or make changes to this bug.