Closed Bug 416906 Opened 13 years ago Closed 13 years ago

Incorrect preprocessor syntax

Categories

(Core :: ImageLib, defect)

Product:
Core
Component:
ImageLib
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9beta4

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

Details

Attachments

(1 file)

Replace "#endif !" with "#endif //"
3.96 KB, patch
pavlov
: review+
mtschrep
: approval1.9+
Details | Diff | Splinter Review 
Patch in bug 411379 introduced some preprocessor abuse. It's non-standard and breaks "idealistic" preprocessors like MCPP.

This is a no-risk patch that gets rid of warnings in GCC.
Attachment #302696 - Flags: review?(pavlov)
Attachment #302696 - Flags: review?(pavlov) → review+
Attachment #302696 - Flags: approval1.9?
Attachment #302696 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Comment on attachment 302696 [details] [diff] [review]
Replace "#endif !" with "#endif //"

C++-style comments in .c files? tsk! I'll change those to /* */ on commit.
Assignee: nobody → tglek
OS: Mac OS X → All
Hardware: PC → All
Checking in jpeg/jdapimin.c;
/cvsroot/mozilla/jpeg/jdapimin.c,v  <--  jdapimin.c
new revision: 3.10; previous revision: 3.9
done
Checking in jpeg/jdcolor.c;
/cvsroot/mozilla/jpeg/jdcolor.c,v  <--  jdcolor.c
new revision: 3.4; previous revision: 3.3
done
Checking in jpeg/jdmaster.c;
/cvsroot/mozilla/jpeg/jdmaster.c,v  <--  jdmaster.c
new revision: 3.4; previous revision: 3.3
done
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
You need to log in before you can comment on or make changes to this bug.