Closed
Bug 416906
Opened 13 years ago
Closed 13 years ago
Incorrect preprocessor syntax
Categories
(Core :: ImageLib, defect)
Core
ImageLib
Tracking
()
RESOLVED
FIXED
mozilla1.9beta4
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
Details
Attachments
(1 file)
3.96 KB,
patch
|
pavlov
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
Patch in bug 411379 introduced some preprocessor abuse. It's non-standard and breaks "idealistic" preprocessors like MCPP. This is a no-risk patch that gets rid of warnings in GCC.
Attachment #302696 -
Flags: review?(pavlov)
Updated•13 years ago
|
Attachment #302696 -
Flags: review?(pavlov) → review+
Assignee | ||
Updated•13 years ago
|
Attachment #302696 -
Flags: approval1.9?
Updated•13 years ago
|
Attachment #302696 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 1•13 years ago
|
||
Comment on attachment 302696 [details] [diff] [review] Replace "#endif !" with "#endif //" C++-style comments in .c files? tsk! I'll change those to /* */ on commit.
Updated•13 years ago
|
Assignee: nobody → tglek
OS: Mac OS X → All
Hardware: PC → All
Comment 2•13 years ago
|
||
Checking in jpeg/jdapimin.c; /cvsroot/mozilla/jpeg/jdapimin.c,v <-- jdapimin.c new revision: 3.10; previous revision: 3.9 done Checking in jpeg/jdcolor.c; /cvsroot/mozilla/jpeg/jdcolor.c,v <-- jdcolor.c new revision: 3.4; previous revision: 3.3 done Checking in jpeg/jdmaster.c; /cvsroot/mozilla/jpeg/jdmaster.c,v <-- jdmaster.c new revision: 3.4; previous revision: 3.3 done
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
You need to log in
before you can comment on or make changes to this bug.
Description
•