416936 - Fix pwrest to validate as HTML 4.01 strict-compliant

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

http://validator.w3.org/check?uri=https%3A%2F%2Fpreview.addons.mozilla.org%2Fen-US%2Fsunbird%2Fusers%2Fpwreset&charset=(detect+automatically)&doctype=Inline&group=0:

Line 164, Column 77: document type does not allow element "INPUT" here; missing one of "P", "H1", "H2", "H3", "H4", "H5", "H6", "PRE", "DIV", "ADDRESS" start-tag.

…ubmit" value="Send password reset link" ></form>

✉

The mentioned element is not allowed to appear in the context in which you've placed it; the other mentioned elements are the only ones that are both allowed there and can contain the element mentioned. This might mean that you need a containing element, or possibly that you've forgotten to close a previous element.

One possible cause for this message is that you have attempted to put a block-level element (such as "<p>" or "<table>") inside an inline element (such as "<a>", "<span>", or "<font>").

Comment 1

[Fred Wenzel [:wenzel]]

Fixed in r10333.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

I don't want to prematurely reopen, but even though this is in SVN head (http://viewvc.svn.mozilla.org/vc/addons/branches/3.2/site/app/views/users/pwreset.thtml?view=log), this isn't yet showing up on preview, for some reason.

I thought we auto-updated/svn-upped on preview?

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening so I don't lose this.

Comment 4

[Michael Morgan [:morgamic]]

Preview has since been updated, and looks fixed.

Comment 5

[Michael Morgan [:morgamic]]

-> wenzel since he fixed it.. :)  ACHTUNG

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Still one validation error; see URL field; reopening.

Comment 7

[Michael Morgan [:morgamic]]

Fixed pwreset form in r11584.

Comment 8

[Fred Wenzel [:wenzel]]

Good job, morgamic: I rechecked and it validates.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified; awesome quick turnaround!