Closed Bug 416944 Opened 16 years ago Closed 1 month ago

Use the "source list" style for the bookmarks manager

Categories

(Camino Graveyard :: Bookmarks, defect)

Product:
Camino Graveyard
Component:
Bookmarks
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: stuart.morgan+bugzilla, Unassigned)

Details

We may well not do this until we are 10.5+ (where there are APIs to make it easy), but now that the source list style (blue background, specific font styling, etc.) is an OS standard we should use it for the bookmarks manager.
If we wanted to do it on 10.4 (and not roll our own), we could use SourceListView II (http://blog.latenightsw.com/?p=352), which is under the same Matt Gemmell license as the MAAttachedWindow class.  (At least the original non-II version supported 10.4; the current version mentions being updated to support the new 10.5 API, so maybe it dropped 10.4 support; someone would have to check.)
Yeah, it's 10.5+ (if not 10.6+) now, from quick inspection of the code and XIB.
Although we really don't need all that anyway; we don't have any hierarchy in our collection list, so it's mostly just a case of messing with backgrounds, fonts.

The bigger change would be making the surrounding splitview and controls look good, probably. Maybe I'll poke at this for kicks, since I haven't done any UI in a while.
(I guess messing with colors and fonts is a lot of what the original did too, so maybe it would be useful.)

We should probably compare 10.4, 10.5, and 10.6 styles before we go too far down this road, to make sure they aren't all so different that we'd go crazy trying to match everything.
Just to record the wrap-up from irc:

We'd rather just make 10.5+ use the new style, via a separate BookmarksEditingNewAndSexy.nib, and leave 10.4 alone (Finder et al. did not use the source list on 10.4, just separate apps like iTunes that were built to run on 10.5 and had to continue supporting 10.4, and used a custom control all around).
I thought this was 2.1? already, but I think our idea here is, time permitting, to try to do this for 2.1, because it's one of the remaining places where we look dated.
Flags: camino2.1?
Stuart, I know you were working on (or at least looking into) this at one point; is it still on your radar for 2.1?
Sort of; getting the window looking reasonable was proving painful. I haven't worked on it since picking up the various b1 work though, so I'll look again once I hit a couple other things on my list.
Stuart, I assume this is out for 2.1 (camino2.1-)?
Yep, no time I'm afraid.
Flags: camino2.1? → camino2.1-
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.