416956 - "Changing the default values" in about:config warning doesn't make a whole lot of sense

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Jesse Ruderman]

"Changing the default values of these advanced settings can be harmful to the stability, security, and performance of this application."

should be simply

"Changing these advanced settings can be harmful to the stability, security, and performance of this application."

because you're not changing the defaults, you're changing the current values

Comment 1

[Jesse Ruderman]

betlzner apparently added the word "default" as part of the fourth attachment in bug 404661.  I wonder why.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I'm guessing he meant "changing these values from their default value".

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

This is technically right, I'm not sure it's worth the late l10n hit, though, so we can fix it after Firefox 3.

Comment 4

[Jesse Ruderman]

Can you explain how it's technically right?  Am I parsing the sentence differently than you?

Comment 5

[Jesse Ruderman]

Or are you saying the bug report is technically right?

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

I'm saying the bug report is technically right :)

Shaver points out that it's likely that localizers have actually translated this with a clearer meaning, and suggests that we change the en-US string, but don't change the entity name, and instead mark the bug late-l10N so they see that we've made this change for clarity.

I'd support that and approve the patch, if someone would like to whip it up.

Comment 7

[Reed Loden [:reed]]

Attachment: patch - v1

Implement Jesse's suggestion purposely without changing the entity, as per beltzner's comments on IRC.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 303283 [details] [diff] [review]
patch - v1

r+uir+a=beltzner

Comment 9

[Reed Loden [:reed]]

Checking in toolkit/locales/en-US/chrome/global/config.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/global/config.dtd,v  <--  config.dtd
new revision: 1.13; previous revision: 1.12
done