Closed Bug 416956 Opened 13 years ago Closed 13 years ago

"Changing the default values" in about:config warning doesn't make a whole lot of sense

Categories

(Core :: General, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla1.9beta4

People

(Reporter: jruderman, Assigned: reed)

References

Details

(Keywords: late-l10n, regression)

Attachments

(1 file)

"Changing the default values of these advanced settings can be harmful to the stability, security, and performance of this application."

should be simply

"Changing these advanced settings can be harmful to the stability, security, and performance of this application."

because you're not changing the defaults, you're changing the current values
betlzner apparently added the word "default" as part of the fourth attachment in bug 404661.  I wonder why.
Blocks: aboutconfig
Keywords: regression
OS: Mac OS X → All
Hardware: PC → All
I'm guessing he meant "changing these values from their default value".
This is technically right, I'm not sure it's worth the late l10n hit, though, so we can fix it after Firefox 3.
Can you explain how it's technically right?  Am I parsing the sentence differently than you?
Or are you saying the bug report is technically right?
I'm saying the bug report is technically right :)

Shaver points out that it's likely that localizers have actually translated this with a clearer meaning, and suggests that we change the en-US string, but don't change the entity name, and instead mark the bug late-l10N so they see that we've made this change for clarity.

I'd support that and approve the patch, if someone would like to whip it up.
Attached patch patch - v1Splinter Review
Implement Jesse's suggestion purposely without changing the entity, as per beltzner's comments on IRC.
Assignee: nobody → reed
Status: NEW → ASSIGNED
Attachment #303283 - Flags: ui-review?(beltzner)
Attachment #303283 - Flags: review?(beltzner)
Attachment #303283 - Flags: approval1.9?
Comment on attachment 303283 [details] [diff] [review]
patch - v1

r+uir+a=beltzner
Attachment #303283 - Flags: ui-review?(beltzner)
Attachment #303283 - Flags: ui-review+
Attachment #303283 - Flags: review?(beltzner)
Attachment #303283 - Flags: review+
Attachment #303283 - Flags: approval1.9?
Attachment #303283 - Flags: approval1.9+
Keywords: checkin-needed
Checking in toolkit/locales/en-US/chrome/global/config.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/global/config.dtd,v  <--  config.dtd
new revision: 1.13; previous revision: 1.12
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
Component: XP Miscellany → General
QA Contact: brendan → general
You need to log in before you can comment on or make changes to this bug.