Closed
Bug 416998
Opened 16 years ago
Closed 16 years ago
Fix the order of member variable initializers for a few constructors
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: jag+mozilla, Assigned: jag+mozilla)
Details
Attachments
(2 files)
16.19 KB,
patch
|
bzbarsky
:
superreview+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
3.37 KB,
patch
|
sayrer
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
Just weeding out compiler warnings about the order of initializing member variables.
Assignee | ||
Updated•16 years ago
|
Attachment #302812 -
Flags: superreview?(bzbarsky)
Updated•16 years ago
|
Attachment #302812 -
Flags: superreview?(bzbarsky) → superreview+
Assignee | ||
Updated•16 years ago
|
Attachment #302812 -
Flags: approval1.9?
Updated•16 years ago
|
Attachment #302812 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 1•16 years ago
|
||
Checked in. Gonna do a quick check on Firefox and Thunderbird and on Linux for all three to see if anything else pops up.
Assignee | ||
Comment 2•16 years ago
|
||
Bugzilla backup
Updated•16 years ago
|
Attachment #304333 -
Flags: review+
Attachment #304333 -
Flags: approval1.9?
Assignee | ||
Comment 3•16 years ago
|
||
Checking in src/Makefile.in; /cvsroot/mozilla/js/src/Makefile.in,v <-- Makefile.in new revision: 3.118; previous revision: 3.117 done Checking in src/Makefile.ref; /cvsroot/mozilla/js/src/Makefile.ref,v <-- Makefile.ref new revision: 3.50; previous revision: 3.49 done Checking in src/README.html; /cvsroot/mozilla/js/src/README.html,v <-- README.html new revision: 3.12; previous revision: 3.11 done Checking in src/js.mak; /cvsroot/mozilla/js/src/js.mak,v <-- js.mak new revision: 3.13; previous revision: 3.12 done Checking in src/jscpucfg.c; /cvsroot/mozilla/js/src/jscpucfg.c,v <-- jscpucfg.c new revision: 3.27; previous revision: 3.26 done Checking in src/jscpucfg.h; /cvsroot/mozilla/js/src/jscpucfg.h,v <-- jscpucfg.h new revision: 3.23; previous revision: 3.22 done Checking in src/jslibmath.h; /cvsroot/mozilla/js/src/jslibmath.h,v <-- jslibmath.h new revision: 3.23; previous revision: 3.22 done Checking in src/jslock.c; /cvsroot/mozilla/js/src/jslock.c,v <-- jslock.c new revision: 3.80; previous revision: 3.79 done Checking in src/jslock.h; /cvsroot/mozilla/js/src/jslock.h,v <-- jslock.h new revision: 3.40; previous revision: 3.39 done Removing src/jsosdep.h; /cvsroot/mozilla/js/src/jsosdep.h,v <-- jsosdep.h new revision: delete; previous revision: 3.21 done Checking in src/jstypes.h; /cvsroot/mozilla/js/src/jstypes.h,v <-- jstypes.h new revision: 3.47; previous revision: 3.46 done Checking in src/prmjtime.c; /cvsroot/mozilla/js/src/prmjtime.c,v <-- prmjtime.c new revision: 3.66; previous revision: 3.65 done
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•16 years ago
|
||
Oops, wrong bug. That was bug 415142.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•16 years ago
|
Attachment #304333 -
Flags: approval1.9? → approval1.9+
Updated•16 years ago
|
Keywords: checkin-needed
Comment 5•16 years ago
|
||
Comment on attachment 304333 [details] [diff] [review] Fixes warnings in Places checkin-needed
Assignee | ||
Comment 6•16 years ago
|
||
I'll check this in in a bit.
Assignee | ||
Comment 7•16 years ago
|
||
Attachment 304333 [details] [diff] checked in.
Keywords: checkin-needed
Assignee | ||
Comment 8•16 years ago
|
||
Hrm, fixed this a while ago (Feb 20, 2008)
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•