41719 - Filter UI: use "untitled" when filter name not given

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect, P3)

Description

[laurel]

Using jun05 commercial build

The message filters ui currently will list a blank line in the filter list if a
filter is added with no filter name specified.  We should instead follow 4.x
behavior (not all platforms did this) and fill in the name with "untitled". 

Side issue in the current version of the ui, is that you cannot add more than
one untitled filter.  4.x allows multiple untitled filters.

Comment 1

[laurel]

Another side issue in the current builds: can't delete an untitled filter
through the ui.

Comment 2

[Alec Flett]

actually with today's build it will pop up an alert dialog telling you you need
a filter name.

filter names actually have to be unique with the current design, though I'm
hoping to change that. Since the alert is there, I'm going to mark this M18 to
come up with a better system

Comment 3

[Alec Flett]

reassigning my filter bugs to gayatrib..

Comment 4

[scottputterman]

reassigning to naving

Comment 5

[Håkan Waara]

Jglick, what do you say about simply adding "Untitled" by default to the
filter-name textfield when a new filter rules dialog pops up? 

Then if the user already has a filter with that name, a dialog will pop up and
notify the user about it.

Comment 6

[jglick]

Would probably be better just to leave it blank and inform the user a Filter 
Name is needed.

Comment 7

[Håkan Waara]

...which makes this bug a WONTFIX.

Navin, your call to VERIFY or REOPEN.

Comment 8

[Matthew T (active 1999-2002)]

Ewww. Entering a filter name is not an obvious part of a user's task when 
creating a filter. So omitting to provide a default name, and then putting up a 
`Ha, ha! You forgot the name!' alert when they've finished, is a bit obnoxious.

Comment 9

[Matthew T (active 1999-2002)]

Ok, reopening. I mean, I know the mail/news team love putting up annoying alert 
boxes at every opportunity ... but really, can't we do better than this?

I suggest that a filter with no name be called `untitled filter'. If that name 
is already taken by an existing filter, try `untitled filter 2', `untitled
filter 3', `untitled filter 4' etc, until you find a name which isn't taken. No 
annoying alert necessary.

Comment 10

[Håkan Waara]

Agreed.  I will come up with a simple fix.

Taking from Naving.

Comment 11

[Håkan Waara]

Attachment: fix

Comment 12

[Håkan Waara]

With the patch, the initial filter name will prefill "untitled filter". If that
name already exists, we start at "untitled filter 2" and so on...

My fix made isDuplicateFilterNameExists() be a one-liner rather than a complex
function that iterates through the whole hierarchy of filters!

Need r= lovin'.

Comment 13

[Doron Rosenberg (IBM)]

hwaara: you have a few dump()'s there that need removing

Comment 14

[Håkan Waara]

Attachment: fix -- with bad dumps removed.

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

sr=[e-mail], but consider: "isDuplicateFilterNameExists" is kind of a
yicky name for a function from an english grammar point of view. 

"duplicateFilterNameExists" sounds better.

Comment 16

[Håkan Waara]

Attachment: fix -- renamed isDuplicate... as ben suggested.

Comment 17

[Doron Rosenberg (IBM)]

r=doron

Comment 18

[tor]

a=tor on behalf of drivers

Comment 19

[Håkan Waara]

fix checked in.

Comment 20

[laurel]

New filter rules dialog is pre-filled with "untitled filter" when launched,
provides unique name  like"untitled filter 2"  if there is already an untitled
filter in the list.  If the "untitled filter" name is wiped out, upon OK to the
rules dialog the user will see a pop-up alert indicating the filter needs a name.

Marking verified with aug27 commercial trunk build: win98, mac OS 9.0 and linux
rh6.2

Comment 21

[Navin Gupta]

hwaara, At least try to get reviews from the module owner before you check it 
in. Also in future please look out for regression. This caused regression 
bug 97204 

Comment 22

[(not reading, please use [e-mail] instead)]

here are brendan's comments on this issue:

My 2 cents: I have been spanked by that alert too, and I would rather have a
default name (not "untitled") that's based on the filter's action (which folder
it goes to), or other filter properties.  E.g., I usually end up filtering
[e-mail] mail into a drivers folder, so why should I have to type
"drivers" into the Name field, under threat of an alert?  Software works for me,
works smarter, and doesn't work me harder -- or I soon stop using it (or hack it
myself into shape, if its source is available [;-)] . 

Comment 23

[jglick]

Sorry for the delay, I was out last week. After reading mpt's comments, I would 
agree his suggestion is a good idea. Brendan's comments, as posted by Seth, I 
think is also a good idea. Maybe we could go with mpt's suggestion for now and 
brendan's as an enhancement in the future.

Comment 24

[(not reading, please use [e-mail] instead)]

thanks jglick for the follow up info.  I'll go log a bug with brendan's RFE.

Comment 25

[Håkan Waara]

Seth, Gerv already filed such a bug.

Comment 26

[jglick]

bug 97353