417241 - Delete button should be disabled when focus is on agenda pane and selected Event is readonly

Status: RESOLVED WORKSFORME

(Calendar :: General, defect)

Description

[Berend Cornelius]

When I tried to implement a solution for this in calendar-common-sets.js. I found out that although my code was seemingly executed correctly I would not toggle the delete-button correctly I debugged into
Thunderbird's Code in "_getControllerForCommand" in globalOverlay.js and I
could clearly see that the wrong commandcontroller was returned when the
command is disabled. To solve the problem one would have to implement an own
command updater:

>   _getControllerForCommand: function(command) {
>     try {
>       var controller = 
>       top.document.commandDispatcher.getControllerForCommand(command);
>       if (controller && controller.isCommandEnabled(command))
>         return controller;
>    }
>     catch(e) {
>     }
>     var controllerCount = window.controllers.getControllerCount();
>     for (var i = 0; i < controllerCount; ++i) {
>       var current = window.controllers.getControllerAt(i);
>       try {
>         if (current.supportsCommand(command) && >current.isCommandEnabled(command))
>         return current;
>      }
>      catch (e) {
>      }
>    }
>    return controller || window.controllers.getControllerForCommand(command);
>   },

Comment 1

[Berend Cornelius]

Attachment: patch

The patch attached shows the current state of my implementation about this problem. It will not apply anymore

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

WFM in latest code, the selection code will soon be revised anyways.