417264 - Bookmarks with special unicode characters are not imported from Safari

Status: RESOLVED FIXED

(Firefox :: Migration, defect, P2)

Description

[Vincent Isambart]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; ja-jp) AppleWebKit/523.15.1 (KHTML, like Gecko) Version/3.0.4 Safari/523.15
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3

When I imported my bookmarks from Safari, all my bookmarks and folders that had Japanese characters in their name were not imported.


Reproducible: Always

Steps to Reproduce:
1. Create a bookmark in Safari with some Japanese characters in them
2. In FF3, click on Import and backup -> Import and select Safari.
Actual Results:  
The bookmark with the Japanese name is not imported.

Expected Results:  
The bookmark with the Japanese name should be imported.

Comment 1

[Marcia Knous [:marcia]]

Confirming on the en-US build using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008021304 Minefield/3.0b4pre. However, this is not limited to just Japanese characters. I quick test using Greek characters yielded the same result. Will have to figure out how to change the summary to reflect that.

Comment 2

[Vincent Isambart]

Note that there is a simple workaround: just export the bookmarks in Safari (in the File menu), and import the generated HTML in Firefox.

Comment 4

[Dietrich Ayala (:dietrich)]

Attachment: fix

Comment 5

[Dietrich Ayala (:dietrich)]

drivers: lets make migration from other browser painless and dataloss-less.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 311745 [details] [diff] [review]
fix

r=mano

Comment 7

[Dietrich Ayala (:dietrich)]

Checking in browser/components/migration/src/nsSafariProfileMigrator.cpp;
/cvsroot/mozilla/browser/components/migration/src/nsSafariProfileMigrator.cpp,v  <--  nsSafariProfileMigrator.cpp
new revision: 1.50; previous revision: 1.49
done

Comment 11

[Dave Townsend [:mossop]]

bug 434473 reports that a similar issue is still visible in Firefox 3 RC1. Should this be reopened?

Comment 13

[Hasham]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008053008 Firefox/3.0

Yeah, the issue seems to be with folders now. Any folder with special unicode characters (including accents as described in Bug 434473) is not imported. I tired, Japanese, French and Chinese and each time, the folder wouldn't import from Safari.

If the link is not sitting in a folder, it will transfer over so only a part of the issue has reemerged.

Steps to reproduce are the same except make sure that you create a *FOLDER* with special unicode characters and try to import that.

Reopening.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Please file a new bug about that issue. REOPENing a bug is almost never a good idea, unless the patch that landed is going to be backed out.

Comment 15

[Hasham]

Gotcha. Filed bug 438744. Sorry about that. :)

Comment 16

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=7717 added to Litmus.