Closed
Bug 41728
Opened 24 years ago
Closed 24 years ago
'javascript:' is case-insensitive; change for nsContextMenu.isLinkSaveable(link)
Categories
(SeaMonkey :: UI Design, defect, P3)
SeaMonkey
UI Design
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jrgmorrison, Assigned: law)
References
()
Details
Here's an amendment to the fix to bug #23690, with earth-shattering consequences (not)! Per bug #41718, protocol schemes are not case-sensitive, so the test for 'javascript:' in nsContextMenu.isLinkSaveable(link) should be modified to do a case-insensitive comparison for 'JaVaScRipT:'. > diff -u nsContextMenu.js~ nsContextMenu.js --- nsContextMenu.js~ Thu Jun 01 20:13:36 2000 +++ nsContextMenu.js Tue Jun 06 15:42:42 2000 @@ -262,10 +262,10 @@ // We must resort to testing the URL string :-(. dump( "Bug! Link.protocol is still undefined!\n" ); var protocol = link.href.substr( 0, 11 ); - return protocol != "javascript:"; + return protocol.toLowerCase() != "javascript:"; } else { // Presume all but javascript: urls are saveable. - return link.protocol != "javascript:"; + return link.protocol.toLowerCase() != "javascript:"; } }, // Open linked-to URL in a new window.
nav triage team: Not a beta1 stopper, marking nsbeta1-
Keywords: nsbeta1-
Too late, Paul :-). Somebody checked in the fix, already.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•