Status
People
(Reporter: aaronr, Assigned: aaronr)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment, 1 obsolete attachment)
|
7.61 KB,
patch
|
Doron Rosenberg (IBM)
:
review+
|
Details | Diff | Splinter Review |
bug 397929 introduced GetMessageMoz in nsIException, so we need to make changes to reflect that. Also as a follow up to that bug, reed had added GetMessageMoz to nsSOAPMessage, but that isn't really needed according to bsmedberg.
Created attachment 303081 [details] [diff] [review] patch fixes webservices build break
Attachment #303081 -
Flags: review?(doronr)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 303081 [details] [diff] [review] patch looks ok, check it in
Attachment #303081 -
Flags: review?(doronr) → review+
reed just explained (https://bugzilla.mozilla.org/show_bug.cgi?id=397929#c15) why he changed it. I guess I shouldn't change it back but make his changes work on Windows. New patch coming.
Created attachment 303126 [details] [diff] [review] patch2 this patch leaves nsSOAPMessage::GetMessageMoz alone, fixes rest of problems.
Attachment #303081 -
Attachment is obsolete: true
Attachment #303126 -
Flags: review?(doronr)
|
|
||
Updated•10 years ago
|
||
Attachment #303126 -
Flags: review?(doronr) → review+
|
||
Comment 5•10 years ago
|
||
Oh, sorry if I gave you the impression that my change was correct. I was doing this without a failing build myself, so I could have easily changed the wrong thing or not enough. I was just trying to say that the build was actually failing for people after bug 397929 landed, and I tried to fix that, but I don't think I got everything, and I could have easily changed the wrong thing. If you feel nsSOAPMessage is wrong, please fix it. Thanks!
checked into the trunk
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
|
||
Updated•3 months ago
|
||
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•