417339 - dynamic changes to xlink:href of svg:feImage don't cause update

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

When I dynamically change the xlink:href of an svg:feImage, nothing gets updated.  If I remove and reinsert the filter element, then things get updated.

Steps to reproduce:
 1. load attached testcase (simplified from layout/tools/reftest/reftest-analyzer.xhtml, which is working around this bug).
 2. press "Toggle feImage".
 3. press "Reinsert content"
(repeat steps 2 and 3 as desired)

Expected results:
 2. the colored square on the right changes from green to red (or vice-versa)
 3. nothing changes

Actual results:
 2. nothing changes
 3. the colored square changes as it should have in step (2)

(I haven't checked whether the spec says anything about dynamic changes; I'm just assuming that in general we're expected to update in response to them.  If the SVG spec makes an exception here, I'm not aware of it.)

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: testcase

Comment 2

[Takeshi Kurosawa :takenspc]

Attachment: fix

It seems a typo, not a feature.

Comment 3

[Reed Loden [:reed]]

Checking in content/svg/content/src/nsSVGFilters.cpp;
/cvsroot/mozilla/content/svg/content/src/nsSVGFilters.cpp,v  <--  nsSVGFilters.cpp
new revision: 1.66; previous revision: 1.65
done

Comment 4

[Jonathan Watt [:jwatt]]

Thanks for the fix taken!