Closed Bug 417339 Opened 15 years ago Closed 15 years ago

dynamic changes to xlink:href of svg:feImage don't cause update

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9beta4

People

(Reporter: dbaron, Assigned: takenspc)

Details

(Keywords: testcase)

Attachments

(2 files)

testcase
3.86 KB, application/xhtml+xml
Details
fix
1.12 KB, patch
longsonr
: review+
roc
: superreview+
mtschrep
: approval1.9+
Details | Diff | Splinter Review 
When I dynamically change the xlink:href of an svg:feImage, nothing gets updated.  If I remove and reinsert the filter element, then things get updated.

Steps to reproduce:
 1. load attached testcase (simplified from layout/tools/reftest/reftest-analyzer.xhtml, which is working around this bug).
 2. press "Toggle feImage".
 3. press "Reinsert content"
(repeat steps 2 and 3 as desired)

Expected results:
 2. the colored square on the right changes from green to red (or vice-versa)
 3. nothing changes

Actual results:
 2. nothing changes
 3. the colored square changes as it should have in step (2)

(I haven't checked whether the spec says anything about dynamic changes; I'm just assuming that in general we're expected to update in response to them.  If the SVG spec makes an exception here, I'm not aware of it.)
Attached file testcase — 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix
        — 
          — Splinter Review
      

    


  
It seems a typo, not a feature.
Assignee: nobody → taken.spc
Status: NEW → ASSIGNED

        Attachment #303667 -
        Flags: review?(longsonr)

        Attachment #303667 -
        Flags: review?(longsonr) → review+

    
  

        Attachment #303667 -
        Flags: superreview?(tor)

        Attachment #303667 -
        Flags: superreview?(tor) → superreview?(roc)

        Attachment #303667 -
        Flags: superreview?(roc) → superreview+

        Attachment #303667 -
        Flags: approval1.9?

    
  

        Attachment #303667 -
        Flags: approval1.9? → approval1.9+

    
  
Keywords: checkin-needed

    
    

    
  
Checking in content/svg/content/src/nsSVGFilters.cpp;
/cvsroot/mozilla/content/svg/content/src/nsSVGFilters.cpp,v  <--  nsSVGFilters.cpp
new revision: 1.66; previous revision: 1.65
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4

    
    

    
  
Thanks for the fix taken!

          You need to log in
          before you can comment on or make changes to this bug.