dynamic changes to xlink:href of svg:feImage don't cause update

RESOLVED FIXED in mozilla1.9beta4

Status

()

Core
SVG
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: dbaron, Assigned: Takeshi Kurosawa)

Tracking

({testcase})

Trunk
mozilla1.9beta4
testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

10 years ago
When I dynamically change the xlink:href of an svg:feImage, nothing gets updated.  If I remove and reinsert the filter element, then things get updated.

Steps to reproduce:
 1. load attached testcase (simplified from layout/tools/reftest/reftest-analyzer.xhtml, which is working around this bug).
 2. press "Toggle feImage".
 3. press "Reinsert content"
(repeat steps 2 and 3 as desired)

Expected results:
 2. the colored square on the right changes from green to red (or vice-versa)
 3. nothing changes

Actual results:
 2. nothing changes
 3. the colored square changes as it should have in step (2)

(I haven't checked whether the spec says anything about dynamic changes; I'm just assuming that in general we're expected to update in response to them.  If the SVG spec makes an exception here, I'm not aware of it.)
(Reporter)

Comment 1

10 years ago
Created attachment 303110 [details]
testcase
(Assignee)

Comment 2

10 years ago
Created attachment 303667 [details] [diff] [review]
fix

It seems a typo, not a feature.
Assignee: nobody → taken.spc
Status: NEW → ASSIGNED
Attachment #303667 - Flags: review?(longsonr)
Attachment #303667 - Flags: review?(longsonr) → review+
(Assignee)

Updated

10 years ago
Attachment #303667 - Flags: superreview?(tor)

Updated

10 years ago
Attachment #303667 - Flags: superreview?(tor) → superreview?(roc)
Attachment #303667 - Flags: superreview?(roc) → superreview+

Updated

10 years ago
Attachment #303667 - Flags: approval1.9?

Updated

10 years ago
Attachment #303667 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in content/svg/content/src/nsSVGFilters.cpp;
/cvsroot/mozilla/content/svg/content/src/nsSVGFilters.cpp,v  <--  nsSVGFilters.cpp
new revision: 1.66; previous revision: 1.65
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
Thanks for the fix taken!
You need to log in before you can comment on or make changes to this bug.