Created attachment 303123 [details] [diff] [review] fix Steps to reproduce: - Ctrl-P to make print dialog appear - Click cancel **crash** in nsDeviceContextSpecGTK::~nsDeviceContextSpecGTK This is happening because mGtkPageSetup and mGtkPrintSettings are never getting initialized, so they have bogus values (0xa5a5a5a5 I think), and the patch for bug 414314 (understandably) assumes that anything non-null is valid. Attaching a simple fix, which just initializes these values to nsnull. It fixes the crash. The patch also makes a few cosmetic s/NULL/nsnull/ changes to the same file, to match our convention.
Summary: Firefox crashes when cancelling printing since checkin of 414314 → Firefox crashes when cancelling printing since checkin of bug 414314
Comment on attachment 303123 [details] [diff] [review] fix You can just take out the null-setters in the destructor, they're pointless.
Created attachment 303137 [details] [diff] [review] fix for landing (with null-setters in destructor removed)
Flags: blocking1.9? → blocking1.9+
"fix for landing" checked in last night. Closing.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
https://litmus.mozilla.org/show_test.cgi?id=5276 added to Litmus.
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.