Closed Bug 417404 Opened 15 years ago Closed 15 years ago

nsCOMPtr version of NS_ProxyRelease() is broken

Categories

(Core :: XPCOM, defect, P1)

Product:
Core
Component:
XPCOM
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dcamp, Assigned: dcamp)

References

Details

Attachments

(1 file)

fix
711 bytes, patch
benjamin
: review+
KaiE
: review+
benjamin
: superreview+
Details | Diff | Splinter Review
Attached patch fix — — Splinter Review 
uses 'doomed' after swapping it out with 'raw'.
Attachment #303200 - Flags: superreview?(benjamin)
Attachment #303200 - Flags: review?(benjamin)
Assignee: nobody → dcamp
Flags: blocking1.9?
Version: unspecified → Trunk
Blocks: 350873
Flags: blocking1.9? → blocking1.9+
Comment on attachment 303200 [details] [diff] [review]
fix

So, without this patch, the code will try to release a null pointer.

I think this code wants to release the value passed in with "doomed",which got moved to "raw", so r=kengert
Attachment #303200 - Flags: review+
Priority: -- → P1
Attachment #303200 - Flags: superreview?(benjamin)
Attachment #303200 - Flags: superreview+
Attachment #303200 - Flags: review?(benjamin)
Attachment #303200 - Flags: review+
Checking in nsProxyRelease.h;
/cvsroot/mozilla/xpcom/glue/nsProxyRelease.h,v  <--  nsProxyRelease.h
new revision: 1.3; previous revision: 1.2
done
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.