417409 - Categories select overlays the "Go" button in JavaScript-disabled views

Status: VERIFIED WORKSFORME

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Summary: Categories select overlays the "Go" button in JavaScript-disabled views

Steps to Reproduce:

1. Disable JavaScript
2. Look at the Category-selection pulldown in search

Expected Results:

Lays out side-by-side with the "Go" button

Actual Results:

See screenshot

Comment 1

[Fred Wenzel [:wenzel]]

Attachment: Go-buttons repositioned

I repositioned the "go" buttons for both the search and the options, to an absolute value slightly off to the side, because it seemed the least invasive into the other items' styles. It's in SVN r10329. See the attachment for how it looks here.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

I hate to reopen--no really, I do!--but I don't like this either.

As is, I agree that your changes are better, since the "Go" buttons are now clearly visible/clickable, but we should beautify this at some later point.

If you're not OK with the reopen/repurpose, resolve it fixed, I'll verify, and spin-off a separate bug.

Comment 3

[Chris Pollett]

Attachment: Fixes go button location; incorparates css changes of category drop down

Under the proposed patch the go button appears with the green search bubble. The patch also includes the css changes of Bug415504 to make the category drop downs wide enough to hold Dictionaries and Encyclopedias.

Comment 4

[Chris Pollett]

Attachment: Fixes the go button problem

Proposed patch to fix the problem

Comment 5

[Chris Pollett]

whoops ignore attachment 308030 [details] [diff] [review], I meant to post it to a different bug.
I still want attachment 307283 [details] [diff] [review] to be considered

Comment 6

[Michael Morgan [:morgamic]]

It looks ok to me.  Reopen if it's still messed up.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Checked on Opera 9.25 (Windows), Safari 2.04 (OS X 10.4) / Safari 3.04 (Vista), and Firefox 2/3, all with JavaScript disabled.

Neither IE 6 nor 7 display the "Search" button, but I've spun that off as bug 422586; this is fixed for the rest of the browsers, so VERIFIED.