41743 - View Image Sites dialog doesn't launch from Prefs dialog

Status: RESOLVED FIXED

(Core :: Graphics: Image Blocking, defect, P3)

Description

[sairuh (rarely reading bugmail)]

saw this using opt bits from 2000.06.06.08; occurs in both mozilla and
commercial (removed the imageblocker pref from all-ns.js there to test).

1. open Prefs dialog.
2. select Advanced > Cookies and Images category.
3. click the "View Sites..." button to open the View Image Sites dialog.

result: the dialog doesn't open. get the following console error:

JavaScript error: 
 line 0: viewImages is not defined

note: still able to open this dialog when selecting the menu item Tasks >
Security and Privacy > Image Manager > View Sites who can/cannot display images.

Comment 1

[Stephen P. Morse]

Someone removed the viewImages() routine from pref-cookies.xul.  I just replaced 
it.  Problem should be fixed now.

Comment 2

[Blake Ross]

Patch is to add this to /xpfe/components/prefwindow/resources/content/pref-
imageblocking.xul:

  function viewImages() 
  {
    window.openDialog
("chrome://communicator/content/wallet/CookieViewer.xul","","modal=yes,chrome,re
sizable=no", 2);
  }  

Comment 3

[Blake Ross]

...as steve was saying while i was :)

Comment 4

[Stephen P. Morse]

Well it would be what I was saying if you didn't make a typo.  You said that the 
patch is to go in pref-imageblocking.xul but I think you meant pref-cookies.xul. 

Comment 5

[Blake Ross]

yep, that's what i meant, sorry [viewImages() is already defined in pref-
imageblocking.xul anyways]

i can vrfy this works on linux, win98 and win2k.  see no reason at all why it 
wouldn't work on mac, but i'll wait for verification (...sairuh?)