View Image Sites dialog doesn't launch from Prefs dialog

RESOLVED FIXED

Status

()

Core
Image Blocking
P3
normal
RESOLVED FIXED
18 years ago
15 years ago

People

(Reporter: sairuh (rarely reading bugmail), Assigned: Stephen P. Morse)

Tracking

({regression})

Trunk
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
saw this using opt bits from 2000.06.06.08; occurs in both mozilla and
commercial (removed the imageblocker pref from all-ns.js there to test).

1. open Prefs dialog.
2. select Advanced > Cookies and Images category.
3. click the "View Sites..." button to open the View Image Sites dialog.

result: the dialog doesn't open. get the following console error:

JavaScript error: 
 line 0: viewImages is not defined

note: still able to open this dialog when selecting the menu item Tasks >
Security and Privacy > Image Manager > View Sites who can/cannot display images.
(Reporter)

Updated

18 years ago
Keywords: regression
(Assignee)

Comment 1

18 years ago
Someone removed the viewImages() routine from pref-cookies.xul.  I just replaced 
it.  Problem should be fixed now.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 2

18 years ago
Patch is to add this to /xpfe/components/prefwindow/resources/content/pref-
imageblocking.xul:

  function viewImages() 
  {
    window.openDialog
("chrome://communicator/content/wallet/CookieViewer.xul","","modal=yes,chrome,re
sizable=no", 2);
  }  

Comment 3

18 years ago
...as steve was saying while i was :)
(Assignee)

Comment 4

18 years ago
Well it would be what I was saying if you didn't make a typo.  You said that the 
patch is to go in pref-imageblocking.xul but I think you meant pref-cookies.xul. 

Comment 5

18 years ago
yep, that's what i meant, sorry [viewImages() is already defined in pref-
imageblocking.xul anyways]

i can vrfy this works on linux, win98 and win2k.  see no reason at all why it 
wouldn't work on mac, but i'll wait for verification (...sairuh?)

Updated

15 years ago
Component: Cookies → Image Blocking
QA Contact: tever → nobody
You need to log in before you can comment on or make changes to this bug.