417442 - Implement a consistent rating scheme

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://remora-reskin.stage.mozilla.com/en-US/firefox/addon/5202 has rating values ranging from 1-5.

Its review page, https://remora-reskin.stage.mozilla.com/en-US/firefox/reviews/add/1865, has values, ranging from 0-10 (oh, and a default value of 5--fligtar makes the poignant comment that we shouldn't have any value pre-selected in https://bugzilla.mozilla.org/show_bug.cgi?id=417417#c1).

We should be consistent in the range of values we offer, obviously.

Comment 1

[Michael Morgan [:morgamic]]

The add-on manager uses 5 stars, we should probably do the same, so we'll have to convert the rating system to 5/5 from 10/10.

Thanks for filing the bug.  Also agree that we shouldn't have a default rating.

Comment 2

[Alfred Kayser]

Note, in my themes I made the display of the 10 level scoring visible, like a 9 becomes 4½ stars.

Comment 3

[Michael Morgan [:morgamic]]

Going with 5.

Comment 4

[Michael Morgan [:morgamic]]

-> me, *buys a big red pen*

Comment 5

[Michael Morgan [:morgamic]]

We'll have to go with rating/2 then editing the review forms.  Stars I'm guessing will be rounded to the nearest star...

Comment 6

[Michael Morgan [:morgamic]]

update reviews set rating = rating/2 where rating > 0 and rating is not null;

That fixes the review ratings column.  The rating cron would fix this in one pass once the values are reduced.

Aside from that, the review form would have to be set to 5 instead of 10...

Comment 7

[Dave Townsend [:mossop]]

What is the ETA on the API returning the new values from this? I was hoping to make the change for b5 since if we make it afterwards b5 users will see half ratings for everything. I have the patch all ready my side.

Comment 8

[Laura Thomson :laura]

Attachment: Patch for the API component of this.

Comment 9

[Laura Thomson :laura]

The API patch and the change to the production database need to be made at the same time.  This is ready to go at my end - any chance tonight?

Comment 10

[Laura Thomson :laura]

API stuff committed in r11375.

The current plan is to push this and the database change Thursday as part of the 3.2 migration.  The Addons Mgr changes are in b5 which goes into code freeze tonight - in the intervening couple of days nightly builds will show incorrect ratings.  Not a huge deal and it was the only way we can really synchronize this.

Comment 12

[Fred Wenzel [:wenzel]]

morgamic, laura: Is this fixed? I believe so.

Comment 13

[Michael Morgan [:morgamic]]

Both fixed, I ran the SQL and the API was updated shortly after 3.2.

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; haven't seen nor heard of any problems with this post-launch.