Closed Bug 417445 Opened 17 years ago Closed 17 years ago

Default Review page <select> value to "choose"

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: stephend, Assigned: cpollett)

References

()

Details

Attachments

(1 file)

Mock says "choose" for the default <select> option value on any given add-on's Detail page: http://mozilla.focalcurve.com/detailpage.html We have this correctly on remora staging/reskin for the same page, but I think we should be consistent and change the default "selected" value of 5 on https://remora-reskin.stage.mozilla.com/en-US/firefox/reviews/add/1865 and the like to be "choose".
Assignee: nobody → cpollett
Chris could you add a default to match the quick form -- like "choose" and also make sure that the form handler doesn't accept "choose" as a rating value?
Target Milestone: --- → 3.2
If you don't select anything initially on the quick form, the review will be submitted. So should I force people to give a rating on both forms or neither?
The description above pretty much describes the patch. I noticed on the quick form that the word "Submit" is not localized. I am not sure if we are still open for new l10n strings so I didn't create one to solve that problem.
Attachment #306705 - Flags: review?(morgamic)
ping. just checking if anyone wants to looks t this patch since its short and I think there was talk about adding stars yesterday.
Comment on attachment 306705 [details] [diff] [review] quick and long review form now both have choose and wont submit unless an int given Works for me -- thanks Chris.
Attachment #306705 - Flags: review?(morgamic) → review+
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: