Reject "choose" as a rating value in our form-submission checks

VERIFIED FIXED in 3.2

Status

addons.mozilla.org Graveyard
Public Pages
VERIFIED FIXED
10 years ago
2 years ago

People

(Reporter: stephend, Assigned: Chris Pollett)

Tracking

Details

(URL)

(Reporter)

Description

10 years ago
The Submit form at https://remora-reskin.stage.mozilla.com/en-US/firefox/addon/1865 lets you submit " " with a rating value of 'choose'.

Conversely, the form-checking behavior at https://remora-reskin.stage.mozilla.com/en-US/firefox/reviews/add/1865 insists that "The rating must be a number".

Pretty sure, then, we should change https://remora-reskin.stage.mozilla.com/en-US/firefox/addon/1865 to not accept "choose" as a value.
(Reporter)

Comment 1

10 years ago
Meant to add: "choose" isn't currently a value in https://remora-reskin.stage.mozilla.com/en-US/firefox/reviews/add/1865 and friends; that's covered by bug 417445, and bug 417442 more generally covers the discrepancy between the way ratings are currently implemented.
This is related to bug 417445
Assignee: nobody → cpollett
Target Milestone: --- → 3.2
(Assignee)

Comment 3

10 years ago
patch to bug 417445. does not accept choose as a value on both forms. If that patch is okay this bug would be resolved to
(Assignee)

Comment 4

10 years ago
patch to 417445 has been committed so should also have fixed this bug
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

10 years ago
Verified FIXED on https://preview.addons.mozilla.org
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.