417491 - Element.setAttribute(':', ...) throws DOMException INVALID_CHARACTER_ERR

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Philip Taylor]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008021304 Minefield/3.0b4pre

Element.setAttribute throws an INVALID_CHARACTER_ERR if the attribute name starts with a colon.

DOM 3 Core requires the attribute name to be an "XML name", which probably means <http://www.w3.org/TR/REC-xml/#NT-Name>, which allows a Name to start with a colon.

Comment 2

[Julian Reschke]

Sound a bit like a bug in the DOM spec, as that attribute name would not be allowed in XML1.0+XMLNS (see http://www.w3.org/TR/REC-xml-names/#NT-NCNameStartChar).

Comment 3

[Peter Van der Beken [:peterv]]

This isn't an exact duplicate of bug 390816, ':' is a valid name start character but I don't think ';' is. We could allow this for createElement/setAttribute I guess :-(.

Comment 4

[Jeff Walden [:Waldo]]

Attachment: Patch

Not sure how I missed this when reading specs in bug 411103.  Question is whether we want to do this or not, I guess...we threw a namespace error in Firefox 2, so no backwards compat concerns here.  It does simplify the code a touch.

Comment 5

[Jeff Walden [:Waldo]]

Comment on attachment 303317 [details] [diff] [review]
Patch

Corrects a minor incompatibility with the DOM core specs...

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 303317 [details] [diff] [review]
Patch

a=beltzner for 1.9

Comment 7

[Jeff Walden [:Waldo]]

Fixed.