XUL Tooltips keep windows alive until shutdown

RESOLVED FIXED in mozilla1.9beta4

Status

()

Core
XUL
P1
normal
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Ben Turner (not reading bugmail, use the needinfo flag!), Assigned: Ben Turner (not reading bugmail, use the needinfo flag!))

Tracking

({mlk})

Trunk
mozilla1.9beta4
Points:
---
Bug Flags:
blocking1.9 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

nsCycleCollector: nsXULTooltipListener 0x217bc040 was not collected due to 36
  external references (38 total - 2 known)
  An object expected to be garbage could be reached from it by the path:
    nsXULTooltipListener 0x217bc040
    nsGenericElement 0x1830f740
    nsEventListenerManager 0x1830f6e0
    nsJSEventListener 0x19705370
    JS Object (ChromeWindow) (global=1645a3c0) 0x1645a3c0
    nsGlobalWindow 0x183eccdc
  The 2 known references to it were from:
    nsEventListenerManager 0x1830f6e0
    nsEventListenerManager 0x1830f6e0

Working on getting a ref tree...
Flags: blocking1.9?

Updated

10 years ago
Keywords: mlk
Assignee: bent.mozilla → nobody
Component: XUL Widgets → XP Toolkit/Widgets: XUL
Product: Toolkit → Core
QA Contact: xul.widgets → xptoolkit.xul
Assignee: nobody → bent.mozilla
Created attachment 303636 [details] [diff] [review]
Use weak refs, v1

Turns out that those external refs were due to the nsCCUncollectableMarker preventing traversion of live windows and documents... Grr.

Anyway, this uses weak refs to prevent the tooltip listener from holding a dead window alive.
Attachment #303636 - Flags: review?(jst)
Attachment #303636 - Flags: review?(jst) → review?(enndeakin)

Comment 2

10 years ago
Comment on attachment 303636 [details] [diff] [review]
Use weak refs, v1

Seems OK, but I don't understand is the nsLayoutStatics.cpp change.

Also, make sure to get a superreview from someone who knows a lot about memory/cycle collector stuff.
Attachment #303636 - Flags: review?(enndeakin)

Updated

10 years ago
Attachment #303636 - Flags: review+
Attachment #303636 - Flags: superreview?(peterv)
Comment on attachment 303636 [details] [diff] [review]
Use weak refs, v1

> diff -NprU8 mozilla.1d899a2c09d9/layout/xul/base/src/nsXULTooltipListener.h mozilla/layout/xul/base/src/nsXULTooltipListener.h

Remove the inclusion of nsCycleCollectionParticipant.h.
Attachment #303636 - Flags: superreview?(peterv) → superreview+
Flags: blocking1.9? → blocking1.9+
Priority: -- → P1
Checked in.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

9 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.