417539 - Remove obsolete event dialog files and strings

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Simon Paquet [:sipaq]]

The calendar-event-dialog.xul and calendar-event-dialog.js files are obsolete, now that the prototype dialog has taken over and has been promoted to be our official event dialog.

We should cvs remove those two files and remove them from jar.mn

The two instances of calendar-event-dialog.css in base/themes and base/content should be purged from unused CSS statements. I don't know if it's possible to merge these two files now.

Last but not least, many of the strings in calendar-event-dialog.dtd are unused (51 out of 78) and can be removed.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I believe some functions of calendar-event-dialog.js are also used in the new dialog. This should be checked before we remove the dialog.

Comment 2

[Simon Paquet [:sipaq]]

Attachment: Patch v1

Philipp, regarding your comment 1 in this bug:

I searched the codebase for any references to calendar-event-dialog.js, but couldn't find any except for the obvious reference in calendar-event-dialog.xul. Therefore I removed the complete file. I tested this by adding a few events and tasks, but could not find any regressions.

Comment 3

[Simon Paquet [:sipaq]]

Attachment: Patch v2

Same patch, but this time with jar.mn changes included.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 319152 [details] [diff] [review]
Patch v2

Looks good, r=philipp

Comment 5

[Simon Paquet [:sipaq]]

Patch checked in on HEAD and MOZILLA_1_8_BRANCH.