Closed Bug 417539 Opened 15 years ago Closed 15 years ago

Remove obsolete event dialog files and strings

Categories

(Calendar :: General, defect)

defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sipaq, Assigned: sipaq)

References

Details

Attachments

(1 file, 1 obsolete file)

The calendar-event-dialog.xul and calendar-event-dialog.js files are obsolete, now that the prototype dialog has taken over and has been promoted to be our official event dialog.

We should cvs remove those two files and remove them from jar.mn

The two instances of calendar-event-dialog.css in base/themes and base/content should be purged from unused CSS statements. I don't know if it's possible to merge these two files now.

Last but not least, many of the strings in calendar-event-dialog.dtd are unused (51 out of 78) and can be removed.
Depends on: 403886
I believe some functions of calendar-event-dialog.js are also used in the new dialog. This should be checked before we remove the dialog.
Attached patch Patch v1 (obsolete) — Splinter Review
Philipp, regarding your comment 1 in this bug:

I searched the codebase for any references to calendar-event-dialog.js, but couldn't find any except for the obvious reference in calendar-event-dialog.xul. Therefore I removed the complete file. I tested this by adding a few events and tasks, but could not find any regressions.
Attachment #319151 - Flags: review?(philipp)
Attached patch Patch v2Splinter Review
Same patch, but this time with jar.mn changes included.
Attachment #319151 - Attachment is obsolete: true
Attachment #319152 - Flags: review?(philipp)
Attachment #319151 - Flags: review?(philipp)
Comment on attachment 319152 [details] [diff] [review]
Patch v2

Looks good, r=philipp
Attachment #319152 - Flags: review?(philipp) → review+
Patch checked in on HEAD and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.