Closed
Bug 417558
Opened 16 years ago
Closed 16 years ago
protect against Obj-C exceptions in "widget" top-level directory
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9
People
(Reporter: jaas, Assigned: jaas)
References
()
Details
Attachments
(4 files, 1 obsolete file)
10.36 KB,
patch
|
stanshebs
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
50.03 KB,
patch
|
stanshebs
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
71.40 KB,
patch
|
bent.mozilla
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
104.57 KB,
patch
|
bent.mozilla
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
For implementing the strategy we decided on in bug 163260 we are filing a bug for each top-level directory that needs work. mozilla/widget
Attachment #303441 -
Flags: review?(stanshebs)
Comment 2•16 years ago
|
||
Attachment #303441 -
Flags: review?(stanshebs) → review+
Attachment #303441 -
Flags: superreview?(roc)
Attachment #303441 -
Flags: superreview?(roc) → superreview+
Attachment #304143 -
Flags: review?
Attachment #304144 -
Flags: review?(stanshebs)
Attachment #304143 -
Attachment is obsolete: true
Attachment #304143 -
Flags: review?
Updated•16 years ago
|
Attachment #304144 -
Flags: review?(stanshebs) → review+
Attachment #304144 -
Flags: superreview?(roc)
Attachment #304144 -
Flags: superreview?(roc) → superreview+
Attachment #304413 -
Flags: review?(bent.mozilla)
Comment on attachment 304413 [details] [diff] [review] still more v1.0 r=me, but you're changing blame for a lot of lines unnecessarily (whitespace changes mostly).
Attachment #304413 -
Flags: review?(bent.mozilla) → review+
Comment on attachment 304413 [details] [diff] [review] still more v1.0 Those changes are to small files with little history anyway, their whitespace is abnormal for cocoa widgets.
Attachment #304413 -
Flags: superreview?(roc)
Assignee | ||
Comment 10•16 years ago
|
||
Attachment #304566 -
Flags: review?(bent.mozilla)
Comment on attachment 304566 [details] [diff] [review] final files v1.0 r=me, but are you sure that NSMakeRange/Rect in the return is safe and will always be so?
Attachment #304566 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Comment 12•16 years ago
|
||
It doesn't matter if it throws. It'll never be executed. Either there is an exception and we die before we get to it, or a correct method impl will return before we get to it.
Attachment #304566 -
Flags: superreview?(roc)
Attachment #304413 -
Flags: superreview?(roc) → superreview+
can 'retain' and 'release' actually throw exceptions???
Attachment #304566 -
Flags: superreview?(roc) → superreview+
Comment 14•16 years ago
|
||
can 'retain' and 'release' actually throw exceptions??? Even if they don't now, Apple doesn't promise that they won't in the future.
Assignee | ||
Comment 15•16 years ago
|
||
We really have no way of knowing whether retain and release are likely to throw. At some point we may decide on a set of methods we don't need to protect against.
Assignee | ||
Comment 16•16 years ago
|
||
"still more v1.0" and "final files v1.0" landed
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 17•15 years ago
|
||
Just for reference. This bug was fixed with v1.310 in CVS: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsChildView.mm&branch=1.368&root=/cvsroot&subdir=mozilla/widget/src/cocoa&command=DIFF_FRAMESET&rev1=1.309&rev2=1.310
Target Milestone: --- → mozilla1.9
You need to log in
before you can comment on or make changes to this bug.
Description
•