417561 - Remove Talkback tagging step from release automation

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect, P3)

Description

[Chris Cooper [:coop] (he/him)]

Now that we are using prebuilt Talkback packages for products on the 1.8 branch (bug 403701), we no longer need to tag the Talkback code as part of a release. We should remove that code from release automation.

Comment 1

[Robert Helmer [:rhelmer]]

Yay for this bug!

So, we already support a bootstrap.cfg useTalkback setting, which if set to 0 will not tag Talkback. Is this good enough?

It's actually up to Tinderbox whether it tries to use Tinderbox or not, so the bootstrap.cfg is only used in the Bootstrap::Tag step AFAICT.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

I guess it's safest to not remove the code for now, in case we need to make a speedy reversal. Seems like we should actually remove it later though.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: useTalkback --> 0 for Fx & Tb 2.0.0.x

Comment 4

[Robert Helmer [:rhelmer]]

Comment on attachment 306480 [details] [diff] [review]
useTalkback --> 0 for Fx & Tb 2.0.0.x

How about staging and nightlies?

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [checked in] useTalkback --> 0 for Fx & Tb 2.0.0.x releases, staging, nightlies, and staging nightlies

Checking in fx-moz18-bootstrap.cfg;
/cvsroot/mozilla/tools/release/configs/fx-moz18-bootstrap.cfg,v  <--  fx-moz18-bootstrap.cfg
new revision: 1.35; previous revision: 1.34
done
Checking in fx-moz18-nightly-bootstrap.cfg;
/cvsroot/mozilla/tools/release/configs/fx-moz18-nightly-bootstrap.cfg,v  <--  fx-moz18-nightly-bootstrap.cfg
new revision: 1.9; previous revision: 1.8
done
Checking in fx-moz18-nightly-staging-bootstrap.cfg;
/cvsroot/mozilla/tools/release/configs/fx-moz18-nightly-staging-bootstrap.cfg,v  <--  fx-moz18-nightly-staging-bootstrap.cfg
new revision: 1.2; previous revision: 1.1
done
Checking in fx-moz18-staging-bootstrap.cfg;
/cvsroot/mozilla/tools/release/configs/fx-moz18-staging-bootstrap.cfg,v  <--  fx-moz18-staging-bootstrap.cfg
new revision: 1.17; previous revision: 1.16
done
Checking in tb-moz18-bootstrap.cfg;
/cvsroot/mozilla/tools/release/configs/tb-moz18-bootstrap.cfg,v  <--  tb-moz18-bootstrap.cfg
new revision: 1.16; previous revision: 1.15
done

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Rob, what do you want to do about cleanup of Bootstrap/Step/Tag/Talkback.pm and the Makefile ? Leave this bug open and come back after a round of releases, make a new bug, not bother ?

Comment 7

[Robert Helmer [:rhelmer]]

(In reply to comment #6)
> Rob, what do you want to do about cleanup of Bootstrap/Step/Tag/Talkback.pm and
> the Makefile ? Leave this bug open and come back after a round of releases,
> make a new bug, not bother ?

I'd like to make sure we make it through a release before we remove support, if that's ok with you :) 

I think it would not be too hard to bring it back even then; we basically would just need to "cvs rm" Talkback.pm and remove the calls to it from Tag.pm, right?

Comment 8

[Robert Helmer [:rhelmer]]

Maybe change this bug summary to "disable talkback for releases" and do a separate bug later? Not sure it's worth bothering, really, but I don't mind removing the code if we're sure we won't use it again.

Comment 9

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

I agree, leaving it in place for another release before removing seems safest - and we've got releases coming up later this week. After that, I'd prefer to fully remove, as it helps simplify the remaining code. 

$0.02.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Ok, back to the pool for this one then.

(In reply to comment #7)
> ... we basically would just need to "cvs rm" Talkback.pm and remove the calls 
> to it from Tag.pm, right?

Also the Makefile and master.cfg, but yeah.

Comment 11

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

We've now shipped 2.0.0.13 and 2.0.0.14. 

Can we now start removing Talkback as detailed in comment#7, comment#10 ?

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

I'm comfy with moving ahead with this now, but no time!

Comment 13

[Chris Cooper [:coop] (he/him)]

Moving closed Future bugs into Release Engineering in preparation for removing the Future component.