Closed
Bug 417708
Opened 17 years ago
Closed 17 years ago
Favicon doesn't load for changed URI
Categories
(Mozilla Labs :: Prism, defect)
Mozilla Labs
Prism
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: matthew.gertner, Assigned: matthew.gertner)
Details
Attachments
(1 file)
|
3.07 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
If I enter a URI into the install shortcut dialog, the favicon (if any) is discovered and displayed. If I then change the URI to something else, however, the throbber is displayed indefinitely. (Turns out that this probably doesn't happen if the second page has the appropriate <link rel="..."> tag, but it definitely does when the favicon location has to be guessed.)
|
Assignee | |
Comment 1•17 years ago
|
||
In a nutshell, the _mimeType property of the download needs to be initialized to null before starting. This wasn't happening the second time through.
I took advantage of the opportunity to remove the iframe's event listeners when the download finishes since there is a cyclical reference otherwise.
Attachment #303523 -
Flags: review?(mark.finkle)
|
||
Updated•17 years ago
|
Attachment #303523 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 2•17 years ago
|
||
Landed
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•