417876 - [lt] Collision of shortcut keys in extension update screen

Status: VERIFIED FIXED

(Mozilla Localizations :: lt / Lithuanian, defect)

Description

[Tomas]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; lt; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; lt; rv:1.8.1.12) Gecko/2008020121 Firefox/2.0.0.12

When Firefox pops out window with available extension updates, Alt-N shortcut is assigned to "Įtraukti šį _naujinimą" and "Įdiegti _naujinimus"

Reproducible: Always

Steps to Reproduce:
1. Install some popular/often updated extensions
2. Wait until updates are available
3. Try using keyboard shortcut (Alt+N) to continue in extension updates screen
Actual Results:  
Action unselects update

Expected Results:  
Alt+N or some other shortcut should allow to press "Įdiegti naujinimus" button.

Comment 1

[Rimas Kudelis [use needinfo to ping]]

Attachment: fix for the bug

Ačiū, Tomai.

Attaching a patch that changes one of the affected accesskeys from "N" to "T". "T' doesn't seem taken there.

Axel, mind giving an approval, please?

Comment 2

[Mic Berman]

gavin, can you help here?

Comment 3

[Rimas Kudelis [use needinfo to ping]]

Just a note: this has been fixed on trunk since February 16th.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

ss tells me that chofmann is taking care of branch l10n approvals while I'm gone. The patch looks fine to me, it's an extremely low risk accesskey change.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> while I'm gone.

Er, while Axel is gone, I meant.

Comment 6

[Rimas Kudelis [use needinfo to ping]]

Attachment: patch v. 2

I've noticed that buttons "Back" and "Cancel" in incompatible extension update dialog also share the same accesskey, and would like to fix that too. Here's a new patch.

Comment 7

[chris hofmann]

Comment on attachment 305585 [details] [diff] [review]
patch v. 2

a=chofmann for the branch.

Comment 8

[Rimas Kudelis [use needinfo to ping]]

Checking in toolkit/chrome/mozapps/extensions/extensions.dtd;
/l10n/l10n/lt/toolkit/chrome/mozapps/extensions/extensions.dtd,v  <--  extensions.dtd
new revision: 1.1.2.13; previous revision: 1.1.2.12
done
Checking in toolkit/chrome/mozapps/extensions/update.properties;
/l10n/l10n/lt/toolkit/chrome/mozapps/extensions/update.properties,v  <--  update.properties
new revision: 1.1.2.7; previous revision: 1.1.2.6
done

Thank you, the patch has been committed

Comment 9

[Rimas Kudelis [use needinfo to ping]]

Verifying as fixed on Linux with the following build:

Mozilla/5.0 (X11; U; Linux i686; lt; rv:1.8.1.13pre) Gecko/20080228 BonEcho/2.0.0.13pre

Comment 10

[Rimas Kudelis [use needinfo to ping]]

Also verifying on Windows with the following build:

Mozilla/5.0 (Windows; U; Windows NT 5.1; lt; rv:1.8.1.13pre) Gecko/20080227 BonEcho/2.0.0.13pre