If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Stop using nsIPref in MainController

RESOLVED FIXED in Camino1.6

Status

Camino Graveyard
General
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Stuart Morgan, Assigned: Stuart Morgan)

Tracking

({fixed1.8.1.13})

unspecified
Camino1.6
x86
Mac OS X
fixed1.8.1.13

Details

Attachments

(1 attachment, 1 obsolete attachment)

v2
2.92 KB, patch
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
Created attachment 303669 [details] [diff] [review]
fix

For some reason we have a direct use of the Gecko pref service in MainController; we should be using the Cocoa wrapper.
Attachment #303669 - Flags: superreview?(mark)
(Assignee)

Comment 1

10 years ago
Created attachment 303671 [details] [diff] [review]
v2

Actually, while I'm at it, there's a unless forward declaration of nsIPrefBranch in KeychainServices.h that should be axed as well.
Attachment #303669 - Attachment is obsolete: true
Attachment #303671 - Flags: superreview?(mark)
Attachment #303669 - Flags: superreview?(mark)
(Assignee)

Updated

10 years ago
Attachment #303671 - Flags: superreview?(mark) → superreview?(mikepinkerton)
Comment on attachment 303671 [details] [diff] [review]
v2

sr=pink
Attachment #303671 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 3

10 years ago
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: fixed1.8.1.13
Resolution: --- → FIXED
Target Milestone: --- → Camino1.6
You need to log in before you can comment on or make changes to this bug.