Closed Bug 417892 Opened 12 years ago Closed 12 years ago

IIDs that need to be updated in multiple places need warning comments

Categories

(Core :: XPCOM, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: dbaron, Assigned: benjamin)

References

()

Details

Bug 412320 copied a bunch of IIDs to a second location without *any* warning at the first location that this was done.  There should be prominent comments above all these IIDs:
http://mxr.mozilla.org/seamonkey/search?string=pseudo-iid
at their primary location in the source tree.

I just wasted a bit of time due to this:  I was testing a simple performance patch in an opt build, trying to figure out why it was crashing.  It became obvious once I switched to a debug build.
Flags: blocking1.9?
warnings like this are the polite thing to do, but we would ship without fixing it.
Flags: blocking1.9? → blocking1.9-
I claim this hurts maintainability (and approachability for newcomers) of our code enough that the patch shouldn't have gone in in the first place without it.
I'll approve a patch; I agree with dbaron, and it looks like others brought up the duplication of IIDs after the checkin.

Did the generated QI scheme actually win perf on Windows or Mac?

/be
Flags: wanted1.9+
> I claim this hurts maintainability (and approachability for newcomers) of our
> code 

Fully agree.

> enough that the patch shouldn't have gone in in the
> first place without it.

Yes, it is a bug. Not a blocker, and we of course would take a patch since the risk is low. 
FWIW, I plan on backing out GQI because it didn't help much, and at that point I'll resolve this WFM.
Assignee: nobody → benjamin
backed out
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.