Closed
Bug 417895
Opened 16 years ago
Closed 16 years ago
valgrind: UMR [@ nsTypedSelection::AddRange]
Categories
(Core :: DOM: Selection, defect, P3)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
mozilla1.9beta4
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
(Keywords: valgrind)
Attachments
(2 files)
|
3.65 KB,
text/plain
|
Details | |
|
5.85 KB,
patch
|
roc
:
review+
roc
:
superreview+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
STR 1. drag-select text on a page using the mouse RESULT UMR of 'mType' here: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/generic/nsSelection.cpp&rev=3.299&root=/cvsroot&mark=5799#5770
see bug 353061
|
Assignee | |
Comment 2•16 years ago
|
||
1. make nsTypedSelection ctors initialize all members (fix) 2. reorder members to save space (makes it 128 bytes from 144 on 64-bit system) 3. (unrelated) make 'mCaretBidiLevel' unsigned to fix a compile warning: nsSelection.cpp:841: warning: overflow in implicit constant conversion
Attachment #303688 -
Flags: superreview?(roc)
Attachment #303688 -
Flags: review?(roc)
|
|
Assignee | |
Comment 3•16 years ago
|
||
Oh, I missed that one. Can we just fix it here since I have a patch? I'll file a enhancement bug on implementing nsISelection::Clone()...
sure
Attachment #303688 -
Flags: superreview?(roc)
Attachment #303688 -
Flags: superreview+
Attachment #303688 -
Flags: review?(roc)
Attachment #303688 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Attachment #303688 -
Flags: approval1.9?
|
||
Comment 5•16 years ago
|
||
Please don't forget to add the valgrind key to bugs found using valgrind.
Keywords: valgrind
|
|
||
Updated•16 years ago
|
Flags: blocking1.9?
|
||
Comment 6•16 years ago
|
||
Comment on attachment 303688 [details] [diff] [review] Patch rev. 1 a1.9+=damons
Attachment #303688 -
Flags: approval1.9? → approval1.9+
Flags: blocking1.9? → blocking1.9+
Priority: -- → P3
|
|
||
Comment 7•16 years ago
|
||
Mats, can you land this?
|
|
Assignee | |
Comment 8•16 years ago
|
||
mozilla/layout/generic/nsSelection.cpp 3.303 mozilla/layout/generic/nsFrameSelection.h 1.27 -> FIXED
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
You need to log in
before you can comment on or make changes to this bug.
Description
•