417904 - Focus ring can end up on an inactive tab and is missing on Mac

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

Bug 303428 was filed as a Firefox bug and has recently been moved to Core. That's good, but for the tabbrowser tabs there's still a simple workaround that we should use until that bug is fixed.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 303699 [details] [diff] [review]
patch

>Index: browser/themes/pinstripe/browser/browser.css

>-.tabbrowser-tab:focus > .tab-image-middle > .tab-text {
>+.tabbrowser-tab[selected="true"]:focus > .tab-image-middle > .tab-text {
>   outline: 1.4pt solid -moz-mac-focusring;
> }

I couldn't get this rule to apply on Mac (or maybe it just doesn't have a noticeable effect). I wonder whether we can remove it.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch + Mac fix

(In reply to comment #2)
> I couldn't get this rule to apply on Mac

That's because pinstripe extends the tabbrowser-tab binding.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: screenshot

That doesn't quite look right. I also tried .tab-text-stack > .tab-text but it isn't quit right either. I guess we can just land this as is and fix it in a followup, or not touch it and leave this to some other bug. Mano said he'd already filed this, not sure if he means bug 415957 or something else.

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch + Mac fix v2

Thanks for the screenshots. Looks like the one on the top is least harmful.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 304580 [details] [diff] [review]
patch + Mac fix v2

a=beltzner for 1.9

Comment 7

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.181; previous revision: 1.180
done
Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.125; previous revision: 1.124
done
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.174; previous revision: 1.173
done