Closed Bug 417904 Opened 15 years ago Closed 15 years ago

Focus ring can end up on an inactive tab and is missing on Mac

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 beta4

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: access, polish)

Attachments

(2 files, 2 obsolete files)

Bug 303428 was filed as a Firefox bug and has recently been moved to Core. That's good, but for the tabbrowser tabs there's still a simple workaround that we should use until that bug is fixed.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #303699 - Flags: review?(gavin.sharp)
Comment on attachment 303699 [details] [diff] [review]
patch

>Index: browser/themes/pinstripe/browser/browser.css

>-.tabbrowser-tab:focus > .tab-image-middle > .tab-text {
>+.tabbrowser-tab[selected="true"]:focus > .tab-image-middle > .tab-text {
>   outline: 1.4pt solid -moz-mac-focusring;
> }

I couldn't get this rule to apply on Mac (or maybe it just doesn't have a noticeable effect). I wonder whether we can remove it.
Attachment #303699 - Flags: review?(gavin.sharp) → review+
Attached patch patch + Mac fix (obsolete) — Splinter Review
(In reply to comment #2)
> I couldn't get this rule to apply on Mac

That's because pinstripe extends the tabbrowser-tab binding.
Attachment #303699 - Attachment is obsolete: true
Attachment #304415 - Flags: review?(gavin.sharp)
Attached image screenshot
That doesn't quite look right. I also tried .tab-text-stack > .tab-text but it isn't quit right either. I guess we can just land this as is and fix it in a followup, or not touch it and leave this to some other bug. Mano said he'd already filed this, not sure if he means bug 415957 or something else.
Thanks for the screenshots. Looks like the one on the top is least harmful.
Attachment #304415 - Attachment is obsolete: true
Attachment #304580 - Flags: review?(gavin.sharp)
Attachment #304415 - Flags: review?(gavin.sharp)
Attachment #304580 - Flags: review?(gavin.sharp) → review+
Attachment #304580 - Flags: approval1.9?
Blocks: 415957
Severity: trivial → normal
Keywords: access
Summary: Focus ring can end up on an inactive tab → Focus ring can end up on an inactive tab and is missing on Mac
Comment on attachment 304580 [details] [diff] [review]
patch + Mac fix v2

a=beltzner for 1.9
Attachment #304580 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.181; previous revision: 1.180
done
Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.125; previous revision: 1.124
done
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.174; previous revision: 1.173
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta4
You need to log in before you can comment on or make changes to this bug.