417924 - Buttons shouldn't drastically increase size of menu bar

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement)

Description

[Damian Shaw [Quan]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3

The home button when moved to the menu bar (File, Edit, etc..) should keep it's new small profile that it has on the bookmark menu and should try not to increase the size of the menu bar.

Reproducible: Always

Steps to Reproduce:
1. Right click menu bar and click customize
2. Drag and drop home button on 
Actual Results:  
Menu bar looks a little garish.

Expected Results:  
The new small form of the home button would be much better placed in the menu bar.

Absolute desired behavior would not to increase the size of the menu bar at all.

Comment 1

[Damian Shaw [Quan]]

I think this should be marked "wanted‑firefox3+" but I can only request on a blocking, so I assume someone with the power to do that will read this comment.

Would be a small bit of polish and very low risk/impact to fix.

Comment 2

[Damian Shaw [Quan]]

Attachment: Screenshot of home button taking up way too much height in menu bar

Comment 3

[Damian Shaw [Quan]]

I realised this applies to all buttons. They all seems to have small form factors and they should all use it for the menu bar.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

Simply add iconsize and defaulticonsize attributes, as bug 407899 allows us to do.

Comment 5

[Bryan Henry]

This definitely does not include OSX as you can't even add buttons to the Menu Bar, so I'm not sure "All" is the right marker here.

Comment 6

[Tony Mechelynck [:tonymec]]

(In reply to comment #5)
> This definitely does not include OSX as you can't even add buttons to the Menu
> Bar, so I'm not sure "All" is the right marker here.
> 

Well, on Linux (where I am) you can, and on Windows (where the reporter is) I suppose you can or he wouldn't have reported it. Maybe PC/All rather than All/All?

Comment 7

[Philip Chee]

With the exception of Apple's server line, most Macs these days are PCs.

Comment 8

[Tony Mechelynck [:tonymec]]

(In reply to comment #7)
> With the exception of Apple's server line, most Macs these days are PCs.

Maybe so; but if it happens on both Windows & Linux, either leave the OS as "All" or open a second bug (which would only be reasonable if _different_ files, e.g. different themes, are responsible for the bug on each OS): I don't see anything stricter than "OS=All" to cover them both.

Comment 9

[Dão Gottwald [:dao]]

The patch also changes the personal toolbar, which is present on Mac.

Comment 10

[Damian Shaw [Quan]]

Code freeze is on Tuesday, will this have check-in before then?

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 304277 [details] [diff] [review]
patch

a=beltzner for 1.9

Comment 12

[Reed Loden [:reed]]

Checking in browser/base/content/browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v  <--  browser.xul
new revision: 1.433; previous revision: 1.432
done

Comment 13

[Damian Shaw [Quan]]

The patch works on new profiles, not on old ones though :=/.

Comment 14

[Dão Gottwald [:dao]]

Reset your toolbars to get the original sizes.