417963 - Switch "Make Text Bigger"/"Zoom In" to Command-+

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Stuart Morgan]

Right now we use Command-= for Make Text Bigger, and we have BrowserWindow mapping Command-+ to the same thing via performKeyEquivalent. That's reasonably accurate for US layouts, but not correct for all international layouts.

As of 10.5, if a menu item has Command-+, and there is no binding for Command-=, then Command-= will trigger the menu item if and only if the = key pressed is also the + key in the current keyboard layout. That's the behavior we want, implemented more accurately and for free.

If we want to do this before we are 10.5+ only, we could change the menu shortcut, and change the manual pKE: mapping to = on 10.4-

Comment 1

[Chris Lawson (gone)]

(In reply to comment #0)
> As of 10.5, if a menu item has Command-+, and there is no binding for
> Command-=, then Command-= will trigger the menu item if and only if the = key
> pressed is also the + key in the current keyboard layout. That's the behavior
> we want, implemented more accurately and for free.

Is that "when running on 10.5" or is that "when linked on 10.5"?

Comment 2

[Stuart Morgan]

I'm not sure; someone would have to test a 10.4 build on 10.5.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Starting with 2.1a1, my plan is to have release builds come off of 10.5 buildhosts (though 2.1 will still be using the 10.4 SDK), so we'll be "linked on 10.5" but not "linked on 10.5 against the 10.5 SDK".

We ought to be able to test whether the SDK (also) matters on 10.5 easily, but if someone works up a patch, I can also push it to CVS trunk temporarily so we get a tinderbox build (built on 10.4 with 10.4 SDK) that we can use to perform Stuart's test, rather than depending on hendy's iBook to spit out a static build for testing.

Comment 4

[Stuart Morgan]

Nice to have, but not a big deal.