418037 - Annotate with comments instead of conditionally adding modules to REQUIRES

Status: RESOLVED WORKSFORME

(Core :: General, defect)

Description

[jag (Peter Annema)]

From bug 73353 comment 52:
> So I'm not so happy about ifdef'd REQUIRES changes -- they make it easy for
> somebody in one configuration to make a change that compiles fine (since they
> have that thing turned on) but that breaks for somebody with the feature off.
> 
> However, they are helpful for automatic testing of whether requires lines are
> still needed.
> 
> Maybe the best thing to do would be a compromise:  comment rather than ifdef? 
> Does that seem reasonable?

Seems reasonable to me. On the other hand I see such comments getting out of date quite easily, while using ifdefs should at least get us bugs filed or the missing module moved to the main REQUIRES line when the tree turns red.

Comment 1

[Serge Gautherie (:sgautherie)]

"R.WorksForMe" after bug 398573.

Reopen if there is something else to do.