418201 - Restrict filter processing to the dirty area

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

With the infrastructure that's just landed on trunk it should be pretty easy to restrict filter computation and intermediate surfaces to rerender just the dirty area (in most cases; some filter primitives would still do the whole area). This would be a huge speedup for use cases like scrolling a large static image with filters and large static backgrounds using filters with some dynamic effects going on on top. Might be worth doing for 1.9.

Comment 1

[Jonathan Watt [:jwatt]]

roc, do you want to block on this?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

No, but we could make it wanted1.9.

Comment 3

[Jonathan Watt [:jwatt]]

Agreed.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Not for 1.9. I'm working on it for the next release.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I have a fix for this in my tree, works great. I'll break it out for submission later.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

-- Take the dirty rect into account when we compute needed-bounding-boxes
-- Ensure that GenerateNormal doesn't apply boundary conditions at the computation rect boundary, but the surface boundary
-- Ensure that Gaussian blur applies boundary conditions at the surface boundary, not the computation rect boundary, but still doesn't let stuff leak out of the filter primitive subregion
-- Some extra Gaussian blur reftests to cover that

Comment 7

[Mats Palmgren (inactive)]

Comment on attachment 329380 [details] [diff] [review]
fix

sr=mats

There are couple of white-space problems from an earlier checkin:
http://hg.mozilla.org/mozilla-central/index.cgi/annotate/tip/content/svg/content/src/nsSVGFilters.cpp#l573
on line 575 and 581, please fix those while you're here.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed 8ffe8a29e52b.