Closed Bug 418211 Opened 16 years ago Closed 16 years ago

Little patch to fix mingw build

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 417477

People

(Reporter: Techrazy.Yang, Unassigned)

Details

Attachments

(1 file)

Again, some changes in the source code break my mingw cross compile build for windows in Linux machine. And I find the problem is that :

 #ifdef _WIN32
 # define JS_INLINE(x) __forceinline x
 #elif defined(__GNUC__)
 # ifndef DEBUG
 ...

But I think _WIN32 indicate that we are compiling for windows but it can't give any information about the compiler. So, I think the suitable MACRO here should be _MSC_VER which is defined only for MS's compiler. 

So, I submit this patch. 
Any advice are welcomed!
Thanks!
Attached patch Little PatchSplinter Review
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: