418279 - Ok button in application details doesn't set selected handler

Status: NEW

(Firefox :: Settings UI, enhancement)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008021804 Minefield/3.0b4pre ID:2008021804

If you choose another handler from within the application details dialog and click on ok afterwards, the action is not updated within the applications list. No error is visible within the Error Console.

STR:

1. Open preferences and go to Applications pane
2. Open drop down box of "Web Feed" entry
3. Choose "Application Details"
4. Select e.g. Google
5. Close the dialog with Ok

The application list still shows the last selected handler and not the new one.

Comment 1

[Florian Quèze [:florian]]

This is the expected behavior.

I think later we may want to add a "Make Default" button, and display in bold in the list the current default application.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

If this is the expected behavior, than it will really confuse people. Why there is an Ok and Cancel button if nothing will be updated?

Thinking as a normal user, I would really expect that the entry I have chosen inside the list of handlers will be taken when clicking the Ok button. Currently the Ok button doesn't make any visual changes. Let the user set his preferred handler in that way. We could move the severity to RFE if wanted.

Comment 3

[Florian Quèze [:florian]]

(In reply to comment #2)

> Why there is an Ok and Cancel button if nothing will be updated?

You can remove an application by mistake and want to cancel this action.

> I would really expect that the entry I have chosen
> inside the list of handlers will be taken when clicking the Ok button.

This dialog is called "Applications Details".  When you click on an item in the list, details of this item are displayed.  Saying you have "chosen" it is your interpretation; when you choose an application outside of this dialog, you click on "Use <application name>" which makes the choice explicit.

I agree that we should provide a way to choose the default application from this dialog.  As I said in comment 1, I think we may want to add a "Make Default" button, and double clicking on an application should probably make it the action.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

An easy for-now solution would be to name the button "Done" instead of "OK".

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)